Skip to contentSkip to conversation

staging: erofs: Add identifier for function definition arguments

PATCH In review Sidong Yang 3 participants 3 messages Jan 8, 2019 – Jan 9, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: erofs: Add identifier for function definition arguments

Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit.

Signed-off-by Sidong Yang <realwakka at gmail.com>
---
 drivers/staging/erofs/xattr.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/staging/erofs/xattr.c +6 -4
index 80dca6a4adbe..59bc5641c4e7 100644
@@ -117,10 +117,12 @@ static int init_inode_xattrs(struct inode *inode)
  *                            and need to be handled
  */
 struct xattr_iter_handlers {
-	int (*entry)(struct xattr_iter *, struct erofs_xattr_entry *);
-	int (*name)(struct xattr_iter *, unsigned int, char *, unsigned int);
-	int (*alloc_buffer)(struct xattr_iter *, unsigned int);
-	void (*value)(struct xattr_iter *, unsigned int, char *, unsigned int);
+	int (*entry)(struct xattr_iter *_it, struct erofs_xattr_entry *entry);
+	int (*name)(struct xattr_iter *_it, unsigned int processed, char *buf,
+		    unsigned int len);
+	int (*alloc_buffer)(struct xattr_iter *_it, unsigned int value_sz);
+	void (*value)(struct xattr_iter *_it, unsigned int processed, char *buf,
+		      unsigned int len);
 };
 
 static inline int xattr_iter_fixup(struct xattr_iter *it)
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Sidong Yang

Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit.

Signed-off-by Sidong Yang <realwakka at gmail.com>

personally looks good to me.

Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>

Thanks,
Gao Xiang

Reviewed-by on v2 1/1
#2 lore raw
In reply to Sidong Yang
Quoted 4 lines · Sidong Yang

Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit.

Signed-off-by Sidong Yang <realwakka at gmail.com>
Reviewed-by Chao Yu <yuchao0 at huawei.com>

Thanks,