Skip to contentSkip to conversation

dio: Fix buffer overflow in case of unknown board

PATCH Superseded Geert Uytterhoeven 2 participants 2 messages Jan 8, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dio: Fix buffer overflow in case of unknown board

With gcc 8.2.0:

drivers/dio/dio.c: In function ‘dio_init’:
drivers/dio/dio.c:240:17: warning: ‘strcpy’ writing 69 or more bytes into a region of size 64 overflows the destination [-Wstringop-overflow=]
strcpy(dev->name,dio_getname(dev->id));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Indeed, if an unknown board is present, the target buffer will overflow. Shorten the unknown board name string to fix this.

---
 drivers/dio/dio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dio/dio.c +1 -1
index 92e78d16b476550c..4ff65c690b04b50b 100644
@@ -90,7 +90,7 @@ static struct dioname names[] =
 #undef DIOFBNAME
 
 static const char *unknowndioname 
-        = "unknown DIO board -- please email <[email protected]>!";
+	= "unknown DIO board, please email [email protected]";
 
 static const char *dio_getname(int id)
 {
Signature · 1 line
2.17.1
#1 lore raw

drivers/dio/dio.c static struct dioname names[] = · line 93

Quoted 6 lines · Geert Uytterhoeven
drivers/dio/dio.c +1 -1
@@ -90,7 +90,7 @@ static struct dioname names[] =
 #undef DIOFBNAME
 
 static const char *unknowndioname 
-        = "unknown DIO board -- please email <[email protected]>!";
+	= "unknown DIO board, please email [email protected]";

This could be declared as an array.

Andreas.

Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."