dmaengine: timb_dma: Use struct_size() in kzalloc()
PATCH 1/1 dmaengine: timb_dma: Use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
--- drivers/dma/timb_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/timb_dma.c +2 -2
@@ -643,8 +643,8 @@ static int td_probe(struct platform_device *pdev) DRIVER_NAME))return -EBUSY ; - td =kzalloc (sizeof (struct timb_dma ) + -sizeof (struct timb_dma_chan ) * pdata->nr_channels,GFP_KERNEL ); + td =kzalloc (struct_size (td, channels, pdata->nr_channels), +GFP_KERNEL );if (!td) { err = -ENOMEM ; goto err_release_region;
Quoted 9 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };
Quoted 8 lines
instance =
kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
kzalloc(struct_size(instance, entry, count), GFP_KERNEL);This code was detected with the help of Coccinelle.
Applied, thanks