Skip to contentSkip to conversation

Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

DISCUSSION Nathan Chancellor 2 participants 2 messages Jan 8, 2019 – Jan 15, 2019

lore
Share & tools
lore
#0 lore raw

Hi all,

Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for DSC support/enable") causes a Clang warning:

drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]

                if (intel_dp->dsc_dpcd)
                ~~  ~~~~~~~~~~^~~~~~~~

1 warning generated.

Did you mean to dereference it or should that print statement just always show? I normally would send a patch myself but since I'm not familiar with this code, I'd rather not shoot in the dark :) especially since it's for a trivial logging statement.

Thanks,
Nathan
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw
Quoted 6 lines · Nathan Chancellor

Hi all,

Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for DSC support/enable") causes a Clang warning:

drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]

Quoted 8 lines
                if (intel_dp->dsc_dpcd)
                ~~  ~~~~~~~~~~^~~~~~~~

1 warning generated.

Did you mean to dereference it or should that print statement just always show? I normally would send a patch myself but since I'm not familiar with this code, I'd rather not shoot in the dark :) especially since it's for a trivial logging statement.

Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning in debugfs"), thanks for the report & review on that one.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center