Skip to contentSkip to conversation

Kconfig label updates

PATCH Bjorn Helgaas 6 participants 8 messages Jan 8, 2019 – Jan 14, 2019

Subsystems (2)
PCI s390
lore
Share & tools
lore

Bjorn Helgaas

author
#0 lore raw

Hi,

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Is there some text expansion of RPA that we could use that would be meaningful to a user, i.e., something he/she might find on a nameplate or in a user manual?

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

config MARCH_Z900
bool "IBM zSeries model z800 and z900"

config MARCH_Z9_109
bool "IBM System z9"

Bjorn

drivers/pci/hotplug/Kconfig +5 -4
index e9f78eb390d2..1c1d145bfd84 100644
@@ -112,7 +112,7 @@ config HOTPLUG_PCI_SHPC
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV
-	tristate "PowerPC PowerNV PCI Hotplug driver"
+	tristate "IBM PowerNV PCI Hotplug driver"
 	depends on PPC_POWERNV && EEH
 	select OF_DYNAMIC
 	help

@@ -125,10 +125,11 @@ config HOTPLUG_PCI_POWERNV
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA
-	tristate "RPA PCI Hotplug driver"
+	tristate "IBM Power Systems RPA PCI Hotplug driver"
 	depends on PPC_PSERIES && EEH
 	help
 	  Say Y here if you have a RPA system that supports PCI Hotplug.
+	  This includes the earlier pSeries and iSeries.
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called rpaphp.

@@ -136,7 +137,7 @@ config HOTPLUG_PCI_RPA
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA_DLPAR
-	tristate "RPA Dynamic Logical Partitioning for I/O slots"
+	tristate "IBM RPA Dynamic Logical Partitioning for I/O slots"
 	depends on HOTPLUG_PCI_RPA
 	help
 	  Say Y here if your system supports Dynamic Logical Partitioning

@@ -157,7 +158,7 @@ config HOTPLUG_PCI_SGI
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_S390
-	bool "System z PCI Hotplug Support"
+	bool "IBM System z PCI Hotplug Support"
 	depends on S390 && 64BIT
 	help
 	  Say Y here if you want to use the System z PCI Hotplug
#1 lore raw
Quoted 7 lines · Bjorn Helgaas

Hi,

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

Quoted 7 lines

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Is there some text expansion of RPA that we could use that would be meaningful to a user, i.e., something he/she might find on a nameplate or in a user manual?

"RISC Platform Architecture" apparently. I couldn't find any documentation written in the last decade that uses the term so it's probably a hold-over from when pseries and iseries had separate hardware platforms. Replacing "RPA" with "pseries" would be the least confusing way to handle it.

Quoted 62 lines

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

config MARCH_Z900
bool "IBM zSeries model z800 and z900"

config MARCH_Z9_109
bool "IBM System z9"

Bjorn

drivers/pci/hotplug/Kconfig +5 -4
index e9f78eb390d2..1c1d145bfd84 100644
@@ -112,7 +112,7 @@ config HOTPLUG_PCI_SHPC
          When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV
-       tristate "PowerPC PowerNV PCI Hotplug driver"
+       tristate "IBM PowerNV PCI Hotplug driver"
        depends on PPC_POWERNV && EEH
        select OF_DYNAMIC
        help

@@ -125,10 +125,11 @@ config HOTPLUG_PCI_POWERNV
          When in doubt, say N.
 
 config HOTPLUG_PCI_RPA
-       tristate "RPA PCI Hotplug driver"
+       tristate "IBM Power Systems RPA PCI Hotplug driver"
        depends on PPC_PSERIES && EEH
        help
          Say Y here if you have a RPA system that supports PCI Hotplug.
+         This includes the earlier pSeries and iSeries.
 
          To compile this driver as a module, choose M here: the
          module will be called rpaphp.

@@ -136,7 +137,7 @@ config HOTPLUG_PCI_RPA
          When in doubt, say N.
 
 config HOTPLUG_PCI_RPA_DLPAR
-       tristate "RPA Dynamic Logical Partitioning for I/O slots"
+       tristate "IBM RPA Dynamic Logical Partitioning for I/O slots"
        depends on HOTPLUG_PCI_RPA
        help
          Say Y here if your system supports Dynamic Logical Partitioning

@@ -157,7 +158,7 @@ config HOTPLUG_PCI_SGI
          When in doubt, say N.
 
 config HOTPLUG_PCI_S390
-       bool "System z PCI Hotplug Support"
+       bool "IBM System z PCI Hotplug Support"
        depends on S390 && 64BIT
        help
          Say Y here if you want to use the System z PCI Hotplug
Acked-by
#2 lore raw
In reply to Bjorn Helgaas
Quoted 69 lines · On Tue, 8 Jan 2019 16:30:24 -0600 Bjorn Helgaas <[email protected]> wrote:

Hi,

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Is there some text expansion of RPA that we could use that would be meaningful to a user, i.e., something he/she might find on a nameplate or in a user manual?

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

config MARCH_Z900
bool "IBM zSeries model z800 and z900"

config MARCH_Z9_109
bool "IBM System z9"

Bjorn

drivers/pci/hotplug/Kconfig +4 -3
index e9f78eb390d2..1c1d145bfd84 100644
@@ -112,7 +112,7 @@ config HOTPLUG_PCI_SHPC
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV
-	tristate "PowerPC PowerNV PCI Hotplug driver"
+	tristate "IBM PowerNV PCI Hotplug driver"
 	depends on PPC_POWERNV && EEH
 	select OF_DYNAMIC
 	help

@@ -125,10 +125,11 @@ config HOTPLUG_PCI_POWERNV
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA
-	tristate "RPA PCI Hotplug driver"
+	tristate "IBM Power Systems RPA PCI Hotplug driver"
 	depends on PPC_PSERIES && EEH
 	help
 	  Say Y here if you have a RPA system that supports PCI Hotplug.
+	  This includes the earlier pSeries and iSeries.
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called rpaphp.

@@ -136,7 +137,7 @@ config HOTPLUG_PCI_RPA
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA_DLPAR
-	tristate "RPA Dynamic Logical Partitioning for I/O slots"
+	tristate "IBM RPA Dynamic Logical Partitioning for I/O slots"
 	depends on HOTPLUG_PCI_RPA
 	help
 	  Say Y here if your system supports Dynamic Logical Partitioning

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_SGI · line 164

Quoted 8 lines
drivers/pci/hotplug/Kconfig +1 -1
@@ -157,7 +158,7 @@ config HOTPLUG_PCI_SGI
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_S390
-	bool "System z PCI Hotplug Support"
+	bool "IBM System z PCI Hotplug Support"
 	depends on S390 && 64BIT
 	help
 	  Say Y here if you want to use the System z PCI Hotplug

The rewording of the HOTPLUG_PCI_S390 entry is fine with me.

Acked-by Martin Schwidefsky <[email protected]>
Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.
#3 lore raw
In reply to Bjorn Helgaas

Hi Bjorn,

Quoted 9 lines · Bjorn Helgaas

Hi,

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Yeah I think just remove it, it's not a well known term and is unlikely to help anyone these days.

It stands for "RISC Platform Architecture", which was some kind of specification for Power machines back in the day, but from what I can tell it was never used in marketing or manuals much (hence so few hits on Google).

Quoted 3 lines

Is there some text expansion of RPA that we could use that would be meaningful to a user, i.e., something he/she might find on a nameplate or in a user manual?

No I don't think so.

Quoted 8 lines

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

TBH these are pretty unhelpful too. PowerNV is not a marketing name and so doesn't appear anywhere much in official manuals or brochures and it's also used on non-IBM branded machines. And pSeries & iSeries were marketing names but are no longer used.

We should probably update that text, but we can do that later, rather than blocking this patch.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_SHPC · line 115

Quoted 10 lines
drivers/pci/hotplug/Kconfig +1 -1
index e9f78eb390d2..1c1d145bfd84 100644
@@ -112,7 +112,7 @@ config HOTPLUG_PCI_SHPC
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV
-	tristate "PowerPC PowerNV PCI Hotplug driver"
+	tristate "IBM PowerNV PCI Hotplug driver"

This is used in non-IBM machines as well.

So perhaps: ?

tristate "IBM/OpenPower PowerNV (bare metal) PCI Hotplug driver"

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 128

Quoted 6 lines
drivers/pci/hotplug/Kconfig +1 -1
@@ -125,10 +125,11 @@ config HOTPLUG_PCI_POWERNV
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA
-	tristate "RPA PCI Hotplug driver"
+	tristate "IBM Power Systems RPA PCI Hotplug driver"

I think just drop RPA here.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 131

Quoted 3 lines
drivers/pci/hotplug/Kconfig +0 -0
 	depends on PPC_PSERIES && EEH
 	help
 	  Say Y here if you have a RPA system that supports PCI Hotplug.

s/RPA/IBM Power Systems/

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 132

Quoted 1 line
drivers/pci/hotplug/Kconfig +1 -0
+	  This includes the earlier pSeries and iSeries.

To be complete:
This includes the earlier System p, System i, pSeries and iSeries.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_RPA · line 140

Quoted 9 lines
drivers/pci/hotplug/Kconfig +1 -1
 	  To compile this driver as a module, choose M here: the
 	  module will be called rpaphp.

@@ -136,7 +137,7 @@ config HOTPLUG_PCI_RPA
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA_DLPAR
-	tristate "RPA Dynamic Logical Partitioning for I/O slots"
+	tristate "IBM RPA Dynamic Logical Partitioning for I/O slots"

Again just drop RPA.

cheers

#4 lore raw
Quoted 13 lines · Michael Ellerman

Hi Bjorn,

Quoted 9 lines · Bjorn Helgaas

Hi,

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Quoted 7 lines

Yeah I think just remove it, it's not a well known term and is unlikely to help anyone these days.

It stands for "RISC Platform Architecture", which was some kind of specification for Power machines back in the day, but from what I can tell it was never used in marketing or manuals much (hence so few hits on Google).

It is basically the predecessor to PAPR "Power Architecture Platform Reference". Which the LoPAPR document is available through power.org. Not sure if there is any desire to adopt PAPR in place of RPA. It is the platform reference doc that outlines how we do DLPAR and PCI Hotplug.

Quoted 13 lines
Quoted 4 lines

Is there some text expansion of RPA that we could use that would be meaningful to a user, i.e., something he/she might find on a nameplate or in a user manual?

No I don't think so.

Quoted 6 lines

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

Quoted 7 lines
Quoted 2 lines

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

TBH these are pretty unhelpful too. PowerNV is not a marketing name and so doesn't appear anywhere much in official manuals or brochures and it's also used on non-IBM branded machines. And pSeries & iSeries were marketing names but are no longer used.

pseries is still used as a machine type for PAPR compliant qemu/kvm instances.

Again, just my 2 cents. I'm pretty open to whatever makes the most sense.

-Tyrel

Quoted 56 lines

We should probably update that text, but we can do that later, rather than blocking this patch.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_SHPC · line 115

Quoted 10 lines
drivers/pci/hotplug/Kconfig +1 -1
index e9f78eb390d2..1c1d145bfd84 100644
@@ -112,7 +112,7 @@ config HOTPLUG_PCI_SHPC
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV
-	tristate "PowerPC PowerNV PCI Hotplug driver"
+	tristate "IBM PowerNV PCI Hotplug driver"

This is used in non-IBM machines as well.

So perhaps: ?

tristate "IBM/OpenPower PowerNV (bare metal) PCI Hotplug driver"

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 128

Quoted 6 lines
drivers/pci/hotplug/Kconfig +1 -1
@@ -125,10 +125,11 @@ config HOTPLUG_PCI_POWERNV
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA
-	tristate "RPA PCI Hotplug driver"
+	tristate "IBM Power Systems RPA PCI Hotplug driver"

I think just drop RPA here.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 131

Quoted 3 lines
drivers/pci/hotplug/Kconfig +0 -0
 	depends on PPC_PSERIES && EEH
 	help
 	  Say Y here if you have a RPA system that supports PCI Hotplug.

s/RPA/IBM Power Systems/

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_POWERNV · line 132

Quoted 1 line
drivers/pci/hotplug/Kconfig +1 -0
+	  This includes the earlier pSeries and iSeries.

To be complete:
This includes the earlier System p, System i, pSeries and iSeries.

drivers/pci/hotplug/Kconfig config HOTPLUG_PCI_RPA · line 140

Quoted 9 lines
drivers/pci/hotplug/Kconfig +1 -1
 	  To compile this driver as a module, choose M here: the
 	  module will be called rpaphp.

@@ -136,7 +137,7 @@ config HOTPLUG_PCI_RPA
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_RPA_DLPAR
-	tristate "RPA Dynamic Logical Partitioning for I/O slots"
+	tristate "IBM RPA Dynamic Logical Partitioning for I/O slots"

Again just drop RPA.

cheers

#5 lore raw
Quoted 18 lines · Tyrel Datwyler
Quoted 9 lines · Michael Ellerman
Quoted 7 lines · Bjorn Helgaas

I want to update the PCI Kconfig labels so they're more consistent and useful to users, something like the patch below. IIUC, the items below are all IBM-related; please correct me if not.

I'd also like to expand (or remove) "RPA" because Google doesn't find anything about "IBM RPA", except Robotic Process Automation, which I think must be something else.

Quoted 7 lines

Yeah I think just remove it, it's not a well known term and is unlikely to help anyone these days.

It stands for "RISC Platform Architecture", which was some kind of specification for Power machines back in the day, but from what I can tell it was never used in marketing or manuals much (hence so few hits on Google).

Quoted 4 lines

It is basically the predecessor to PAPR "Power Architecture Platform Reference". Which the LoPAPR document is available through power.org. Not sure if there is any desire to adopt PAPR in place of RPA. It is the platform reference doc that outlines how we do DLPAR and PCI Hotplug.

True. But a user is unlikely to know "PAPR" either, and it googles badly.

LoPAPR I guess is better, you can google for it, though I'm not entirely sure if everything used by this code is actually in LoPAPR, because some bits of PAPR were ripped out of LoPAPR.

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

Ideally the PCI Kconfig labels would match the terms used in arch/.../Kconfig, e.g.,

config PPC_POWERNV
bool "IBM PowerNV (Non-Virtualized) platform support"

config PPC_PSERIES
bool "IBM pSeries & new (POWER5-based) iSeries"

Quoted 6 lines
Quoted 4 lines

TBH these are pretty unhelpful too. PowerNV is not a marketing name and so doesn't appear anywhere much in official manuals or brochures and it's also used on non-IBM branded machines. And pSeries & iSeries were marketing names but are no longer used.

pseries is still used as a machine type for PAPR compliant qemu/kvm instances.

Yeah so I guess it's helpful for someone configuring a kernel with that in mind.

But if you've bought an IBM branded system the "pseries" name is not used anywhere AFAIK.

cheers

#6 lore raw
Quoted 7 lines · Michael Ellerman
Quoted 4 lines · Tyrel Datwyler

It is basically the predecessor to PAPR "Power Architecture Platform Reference". Which the LoPAPR document is available through power.org. Not sure if there is any desire to adopt PAPR in place of RPA. It is the platform reference doc that outlines how we do DLPAR and PCI Hotplug.

True. But a user is unlikely to know "PAPR" either, and it googles badly.

Googling for "powerpc papr" works fine afais? With a working link to a pdf on the first page and all!

Segher

#7 lore raw
Quoted 11 lines · Segher Boessenkool
Quoted 7 lines · Michael Ellerman
Quoted 4 lines · Tyrel Datwyler

It is basically the predecessor to PAPR "Power Architecture Platform Reference". Which the LoPAPR document is available through power.org. Not sure if there is any desire to adopt PAPR in place of RPA. It is the platform reference doc that outlines how we do DLPAR and PCI Hotplug.

True. But a user is unlikely to know "PAPR" either, and it googles badly.

Googling for "powerpc papr" works fine afais? With a working link to a pdf on the first page and all!

True if you know to add "powerpc".

I only get a link to LoPAPR, which is similar but not identical. If there's a link to PAPR then someone is in trouble :)

cheers