fs/buffer.c: include fs/internal.h for missing prototypes
PATCH RESEND 1/1 fs/buffer.c: include fs/internal.h for missing prototypes
From: Eric Biggers <[email protected]>
__block_write_begin_int(), __generic_write_end(), and guard_bio_eod() are defined in fs/buffer.c and declared in fs/internal.h, but the declarations aren't included at the point of the definitions. Include the header to enforce that the definitions match the declarations.
This addresses gcc warnings when -Wmissing-prototypes is enabled.
--- fs/buffer.c | 1 + 1 file changed, 1 insertion(+)
fs/buffer.c +1 -0
@@ -46,6 +46,7 @@#include <linux/pagevec.h> #include <linux/sched/mm.h> #include <trace/events/block.h> +#include "internal.h" static int fsync_buffers_list (spinlock_t *lock,struct list_head *list); static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
Signature · 1 line
2.20.1.97.g81188d93c3-goog
Quoted 29 lines · Eric Biggers
From: Eric Biggers <[email protected]>
__block_write_begin_int(),__generic_write_end(), andguard_bio_eod()are defined infs/buffer.cand declared infs/internal.h, but the declarations aren't included at the point of the definitions. Include the header to enforce that the definitions match the declarations.This addresses gcc warnings when -Wmissing-prototypes is enabled.
Signed-off-by Eric Biggers <[email protected]>--- fs/buffer.c | 1 + 1 file changed, 1 insertion(+)fs/buffer.c +1
-0@@ -46,6 +46,7 @@#include <linux/pagevec.h> #include <linux/sched/mm.h> #include <trace/events/block.h> +#include "internal.h" static int fsync_buffers_list (spinlock_t *lock,struct list_head *list); static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,Signature · 1 line
2.20.1.97.g81188d93c3-goog
Ping. Al, are you planning to apply this?
- Eric