Skip to contentSkip to conversation

fs/namespace.c: make to_mnt_ns() static

PATCH RESEND In review Eric Biggers 1 participant 2 messages Jan 10, 2019 – Feb 7, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 fs/namespace.c: make to_mnt_ns() static

From: Eric Biggers <[email protected]>

to_mnt_ns() is only used in fs/namespace.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index a677b59efd74e..2ba0dbd8573a2 100644
@@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
Signature · 1 line
2.20.1.97.g81188d93c3-goog
#1 lore raw
Quoted 27 lines · Eric Biggers

From: Eric Biggers <[email protected]>

to_mnt_ns() is only used in fs/namespace.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index a677b59efd74e..2ba0dbd8573a2 100644
@@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
Signature · 1 line
2.20.1.97.g81188d93c3-goog

Ping. Al, are you planning to apply this?

- Eric