Skip to contentSkip to conversation

build: use static deps of libs for pkg-config libs.private

PATCH Applied Luca Boccassi 2 participants 2 messages Jan 11, 2019 – Jan 14, 2019 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: use static deps of libs for pkg-config libs.private

Dependencies of the RTE libraries were not being added to the Requires.private field of the pc file since the variable used for dynamic linking was passed to the related field of pkg.generate. Use the static one so that dependencies are included.

Fixes 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")

---
split from the other series, it's a stand-alone non-invasive change

 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -1
index 426e0bf3a..d500507c5 100644
@@ -81,7 +81,7 @@ pkg.generate(name: meson.project_name(),
 	filebase: 'lib' + meson.project_name().to_lower(),
 	version: meson.project_version(),
 	libraries: dpdk_libraries,
-	libraries_private: dpdk_drivers + dpdk_libraries +
+	libraries_private: dpdk_drivers + dpdk_static_libraries +
 			['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
 	description: '''The Data Plane Development Kit (DPDK).
 Note that CFLAGS might contain an -march flag higher than typical baseline.
Signature · 1 line
2.20.1
#1 lore raw

11/01/2019 17:12, Luca Boccassi:

Quoted 11 lines

Dependencies of the RTE libraries were not being added to the Requires.private field of the pc file since the variable used for dynamic linking was passed to the related field of pkg.generate. Use the static one so that dependencies are included.

Fixes 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")

---
split from the other series, it's a stand-alone non-invasive change

Applied, thanks