Skip to contentSkip to conversation

smbus: Remove unneeded include

PATCH In review BALATON Zoltan 3 participants 3 messages Jan 12, 2019 – Jan 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smbus: Remove unneeded include

The file no longer uses error_report after review so the header is not needed either.

---
Forgot to delete this when rewriting after review. This can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0

 hw/i2c/smbus_eeprom.c | 1 -
 1 file changed, 1 deletion(-)
hw/i2c/smbus_eeprom.c +0 -1
index bef24a1ca4..01b9439014 100644
@@ -23,7 +23,6 @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/error-report.h"
 #include "qemu/units.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
Signature · 1 line
2.13.7
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · BALATON Zoltan

The file no longer uses error_report after review so the header is not needed either.

---
Forgot to delete this when rewriting after review. This can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0

 hw/i2c/smbus_eeprom.c | 1 -
 1 file changed, 1 deletion(-)
hw/i2c/smbus_eeprom.c +0 -0
index bef24a1ca4..01b9439014 100644

hw/i2c/smbus_eeprom.c line 28

Quoted 7 lines
hw/i2c/smbus_eeprom.c +0 -1
@@ -23,7 +23,6 @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/error-report.h"
 #include "qemu/units.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
Reviewed-by on v1 1/1
#2 lore raw
In reply to BALATON Zoltan
Quoted 4 lines · BALATON Zoltan

The file no longer uses error_report after review so the header is not needed either.

Quoted 20 lines

---
Forgot to delete this when rewriting after review. This can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0

 hw/i2c/smbus_eeprom.c | 1 -
 1 file changed, 1 deletion(-)
hw/i2c/smbus_eeprom.c +0 -1
index bef24a1ca4..01b9439014 100644
@@ -23,7 +23,6 @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/error-report.h"
 #include "qemu/units.h"
 #include "qapi/error.h"
 #include "hw/hw.h"