Skip to contentSkip to conversation

pwm: imx: Fix undefined symbol

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jan 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: imx: Fix undefined symbol

Fix the following compile error:

drivers/pwm/pwm-imx27.c:292:25: error: 'imx_pwm_dt_ids' undeclared here (not in a function); did you mean 'pwm_imx27_dt_ids'?

Fixes 5a309d380019 ("pwm: imx: Split into two drivers")
---
 drivers/pwm/pwm-imx27.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-imx27.c +1 -1
index 8997c4c1bd03..55666cca4cee 100644
@@ -289,7 +289,7 @@ static const struct of_device_id pwm_imx27_dt_ids[] = {
 	{ .compatible = "fsl,imx27-pwm", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, imx_pwm_dt_ids);
+MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
 
 static int pwm_imx27_probe(struct platform_device *pdev)
 {
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Gustavo A. R. Silva

Fix the following compile error:

drivers/pwm/pwm-imx27.c:292:25: error: 'imx_pwm_dt_ids' undeclared here (not in a function); did you mean 'pwm_imx27_dt_ids'?

Fixes 5a309d380019 ("pwm: imx: Split into two drivers")
---
 drivers/pwm/pwm-imx27.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-imx27.c +0 -0
index 8997c4c1bd03..55666cca4cee 100644

drivers/pwm/pwm-imx27.c static const struct of_device_id pwm_imx27_dt_ids[] = { · line 292

Quoted 5 lines
drivers/pwm/pwm-imx27.c +1 -1
@@ -289,7 +289,7 @@ static const struct of_device_id pwm_imx27_dt_ids[] = {
 	{ .compatible = "fsl,imx27-pwm", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, imx_pwm_dt_ids);
+MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);

The patch is fine, you're at least the fourth person noticing this problem (but the first to send an applicable patch). So if Thierry doesn't want to squash the fix into the offending commit (which I would prefer to not break bisecability), taking this one is the next best option.

If so:

Best regards and thanks,
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |