regmap-irq: do not write mask register if mask_base is zero
Subsystems (3)
PATCH 1/1 regmap-irq: do not write mask register if mask_base is zero
If client have not provided the mask base register then do not write into the mask register.
--- drivers/base/regmap/regmap-irq.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/base/regmap/regmap-irq.c +6 -0
@@ -108,6 +108,9 @@ static void regmap_irq_sync_unlock(struct irq_data *data)* suppress pointless writes. */ for (i =0 ; i < d->chip->num_regs; i++) { +if (!d->chip->mask_base) +continue ; + reg = d->chip->mask_base + (i * map->reg_stride * d->irq_reg_stride);if (d->chip->mask_invert) {
@@ -588,6 +591,9 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,/* Mask all the interrupts by default */ for (i =0 ; i < chip->num_regs; i++) { d->mask_buf[i] = d->mask_buf_def[i]; +if (!chip->mask_base) +continue ; + reg = chip->mask_base + (i * map->reg_stride * d->irq_reg_stride);if (chip->mask_invert)
Signature · 1 line
2.19.2
Some background infos:
This patch fixes an issue when using max77620 gpio driver.
The issue is that, max77620 doesn't have a dedicated GPIO interrupt mask register. If you want to mask a separate GPIO interrupt on max77620, you need to do that in it's type register(starting from register address 0x36 - 0x3D).
So this means we can't find a proper register for "mask_base" property, while in current regmap-irq.c, it updates mask registers assuming "mask_base" is always provided.
Maybe this patch is not the cleanest way to fix the issue, e.g: some chip's mask register address is zero, in that case, could you help to suggest what is the right way?
Thanks,
Mark
Quoted 36 lines · Mark Zhang
If client have not provided the mask base register then do not write into the mask register.
Signed-off-by Laxman Dewangan <[email protected]>Signed-off-by Jinyoung Park <[email protected]>Signed-off-by Venkat Reddy Talla <[email protected]>Signed-off-by Mark Zhang <[email protected]>--- drivers/base/regmap/regmap-irq.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/base/regmap/regmap-irq.c +6
-0@@ -108,6 +108,9 @@ static void regmap_irq_sync_unlock(struct irq_data *data)* suppress pointless writes. */ for (i =0 ; i < d->chip->num_regs; i++) { +if (!d->chip->mask_base) +continue ; + reg = d->chip->mask_base + (i * map->reg_stride * d->irq_reg_stride);if (d->chip->mask_invert) {@@ -588,6 +591,9 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,/* Mask all the interrupts by default */ for (i =0 ; i < chip->num_regs; i++) { d->mask_buf[i] = d->mask_buf_def[i]; +if (!chip->mask_base) +continue ; + reg = chip->mask_base + (i * map->reg_stride * d->irq_reg_stride);if (chip->mask_invert)