Skip to contentSkip to conversation

lib/cmdline.c:: annotate implicit fall throughs

PATCH Superseded Mathieu Malaterre 2 participants 2 messages Jan 14, 2019 Library code

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/cmdline.c:: annotate implicit fall throughs

There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up.

This commit remove the following warnings:

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 lib/cmdline.c | 5 +++++
 1 file changed, 5 insertions(+)
lib/cmdline.c +5 -0
index 171c19b6888e..dc59d6216318 100644
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
 	case 'E':
 	case 'e':
 		ret <<= 10;
+		/* fall through */
 	case 'P':
 	case 'p':
 		ret <<= 10;
+		/* fall through */
 	case 'T':
 	case 't':
 		ret <<= 10;
+		/* fall through */
 	case 'G':
 	case 'g':
 		ret <<= 10;
+		/* fall through */
 	case 'M':
 	case 'm':
 		ret <<= 10;
+		/* fall through */
 	case 'K':
 	case 'k':
 		ret <<= 10;
Signature · 1 line
2.19.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Mathieu Malaterre

There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up.

This commit remove the following warnings:

Quoted 7 lines

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 33 lines
---
  lib/cmdline.c | 5 +++++
  1 file changed, 5 insertions(+)
lib/cmdline.c +5 -0
index 171c19b6888e..dc59d6216318 100644
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
  	case 'E':
  	case 'e':
  		ret <<= 10;
+		/* fall through */
  	case 'P':
  	case 'p':
  		ret <<= 10;
+		/* fall through */
  	case 'T':
  	case 't':
  		ret <<= 10;
+		/* fall through */
  	case 'G':
  	case 'g':
  		ret <<= 10;
+		/* fall through */
  	case 'M':
  	case 'm':
  		ret <<= 10;
+		/* fall through */
  	case 'K':
  	case 'k':
  		ret <<= 10;