Skip to contentSkip to conversation

lib/assoc_array: annotate implicit fall through

PATCH In review Mathieu Malaterre 2 participants 2 messages Jan 14, 2019 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/assoc_array: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 lib/assoc_array.c | 1 +
 1 file changed, 1 insertion(+)
lib/assoc_array.c +1 -0
index c6659cb37033..0b61d3b77e5c 100644
@@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
 						index_key))
 				goto found_leaf;
 		}
+		/* fall through */
 	case assoc_array_walk_tree_empty:
 	case assoc_array_walk_found_wrong_shortcut:
 	default:
Signature · 1 line
2.19.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Mathieu Malaterre

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 17 lines
---
  lib/assoc_array.c | 1 +
  1 file changed, 1 insertion(+)
lib/assoc_array.c +1 -0
index c6659cb37033..0b61d3b77e5c 100644
@@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
  						index_key))
  				goto found_leaf;
  		}
+		/* fall through */
  	case assoc_array_walk_tree_empty:
  	case assoc_array_walk_found_wrong_shortcut:
  	default: