genirq: annotate implicit fall through
PATCH 1/1 genirq: annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/irq/manage.c:725:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by Mathieu Malaterre <[email protected]>
--- kernel/irq/manage.c | 1 + 1 file changed, 1 insertion(+)
kernel/irq/manage.c +1 -0
@@ -723,6 +723,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned long flags)case IRQ_SET_MASK_OK_DONE :irqd_clear (&desc->irq_data,IRQD_TRIGGER_MASK );irqd_set (&desc->irq_data, flags); +/* fall through */ case IRQ_SET_MASK_OK_NOCOPY : flags =irqd_get_trigger_type (&desc->irq_data);
Signature · 1 line
2.19.2
tip-bot for Mathieu Malaterre
merge bot[tip:irq/core] genirq: Annotate implicit fall through
genirq: Annotate implicit fall through
Commit-ID: 44133f7eaebec227d1381868d642e3c64023520f Gitweb: https://git.kernel.org/tip/44133f7eaebec227d1381868d642e3c64023520f Author: Mathieu Malaterre <[email protected]> AuthorDate: Mon, 14 Jan 2019 21:31:54 +0100 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 15 Jan 2019 10:40:34 +0100
genirq: Annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough. The fallthrough in __irq_set_trigger() lacks an annotation. Add it.
Signed-off-by Mathieu Malaterre <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
--- kernel/irq/manage.c | 1 + 1 file changed, 1 insertion(+)
kernel/irq/manage.c +1 -0
@@ -723,6 +723,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned long flags)case IRQ_SET_MASK_OK_DONE :irqd_clear (&desc->irq_data,IRQD_TRIGGER_MASK );irqd_set (&desc->irq_data, flags); +/* fall through */ case IRQ_SET_MASK_OK_NOCOPY : flags =irqd_get_trigger_type (&desc->irq_data);