Skip to contentSkip to conversation

signal: annotate implicit fall through

PATCH In review Mathieu Malaterre 2 participants 3 messages Jan 14, 2019 – Apr 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 signal: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
kernel/signal.c +1 -0
index e1d7ad8e6ab1..aa7a507757d7 100644
@@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
 			 */
 			if (!sid || sid == task_session(current))
 				break;
+			/* fall through */
 		default:
 			return -EPERM;
 		}
Signature · 1 line
2.19.2
#1 lore raw

ping ?

Quoted 28 lines · Mathieu Malaterre

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
kernel/signal.c +1 -1
index e1d7ad8e6ab1..aa7a507757d7 100644
@@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
                         */
                        if (!sid || sid == task_session(current))
                                break;
+                       /* fall through */
                default:
                        return -EPERM;
                }
--

2.19.2

#2 lore raw

[+cc Andrew]

Quoted 2 lines · Mathieu Malaterre

ping ?

Maybe Andrew can take this?

Thanks
--
Gustavo

Quoted 29 lines · Mathieu Malaterre
Quoted 28 lines

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
kernel/signal.c +1 -1
index e1d7ad8e6ab1..aa7a507757d7 100644
@@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
                         */
                        if (!sid || sid == task_session(current))
                                break;
+                       /* fall through */
                default:
                        return -EPERM;
                }
--

2.19.2