Skip to contentSkip to conversation

firewire: annotate implicit fall through

PATCH New Mathieu Malaterre 1 participant 1 message Jan 14, 2019 Firewire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

drivers/firewire/core-topology.c:69:23: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 drivers/firewire/core-topology.c | 1 +
 1 file changed, 1 insertion(+)
drivers/firewire/core-topology.c +1 -0
index 7db234d3fbdd..82c67e900aad 100644
@@ -67,6 +67,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count, int *child_port_count)
 		switch (port_type) {
 		case SELFID_PORT_CHILD:
 			(*child_port_count)++;
+			/* fall through */
 		case SELFID_PORT_PARENT:
 		case SELFID_PORT_NCONN:
 			(*total_port_count)++;
Signature · 1 line
2.19.2