ov7670: Remove useless use of a ret variable

PATCH New Sakari Ailus 1 participant 1 message Jan 14, 2019

Subsystems (3)

Media (V4L/DVB) V4L2 camera sensor drivers Omnivision OV7670 sensor driver

lore

Share & tools

lore

Sakari Ailus

author maintainer

2019-01-14 23:05 UTC #0 lore raw

PATCH 1/1 ov7670: Remove useless use of a ret variable

Instead of assigning the return value to ret and then checking and returning it, just return the value to the caller directly. The success value is always 0.

Signed-off-by Sakari Ailus <[email protected]>

---
 drivers/media/i2c/ov7670.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

drivers/media/i2c/ov7670.c +1 -5

index 4939a83b50e4..61c47c61c693 100644
@@ -859,11 +859,7 @@ static int ov7675_set_framerate(struct v4l2_subdev *sd,
 	/* Recalculate frame rate */
 	ov7675_get_framerate(sd, tpf);
 
-	ret = ov7670_write(sd, REG_CLKRC, info->clkrc);
-	if (ret < 0)
-		return ret;
-
-	return 0;
+	return ov7670_write(sd, REG_CLKRC, info->clkrc);
 }
 
 static void ov7670_get_framerate_legacy(struct v4l2_subdev *sd,

Signature · 1 line

2.11.0