media: s5k4ecgx: delete a bogus error message

PATCH New Dan Carpenter 1 participant 1 message Jan 15, 2019

Subsystems (3)

Media (V4L/DVB) Kernel janitors V4L2 camera sensor drivers

lore

Share & tools

lore

Dan Carpenter

author

2019-01-15 19:54 UTC #0 lore raw

PATCH 1/1 media: s5k4ecgx: delete a bogus error message

This function prints an error message on success. I don't have the hardware, I just noticed this while reading the code.

Fixes 8b99312b7214 ("[media] Add v4l2 subdev driver for S5K4ECGX sensor")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/media/i2c/s5k4ecgx.c | 2 --
 1 file changed, 2 deletions(-)

drivers/media/i2c/s5k4ecgx.c +0 -2

index 79aa2740edc4..79c1894c2c83 100644
@@ -263,8 +263,6 @@ static int s5k4ecgx_read(struct i2c_client *client, u32 addr, u16 *val)
 		ret = s5k4ecgx_i2c_write(client, REG_CMDRD_ADDRL, low);
 	if (!ret)
 		ret = s5k4ecgx_i2c_read(client, REG_CMDBUF0_ADDR, val);
-	if (!ret)
-		dev_err(&client->dev, "Failed to execute read command\n");
 
 	return ret;
 }

Signature · 1 line

2.17.1