Skip to contentSkip to conversation

bitbake.conf: reset default value of DEBUG_PREFIX_MAP

PATCH In review [email protected] 6 participants 14 messages Jan 17, 2019 – Jan 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf: reset default value of DEBUG_PREFIX_MAP

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including -fmacro-prefix-map and -fdebug-prefix-map currently. Option -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused by __FILE__ macro expansion for packages such as llvm and librepo.

---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/bitbake.conf +3 -3
index 0bdcd04d74..d20460e845 100644
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
 # Optimization flags.
 ##################################################################
 # Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 
Signature · 1 line
2.20.0
#1 lore raw

PATCH 1/1 libidn2: fix buildpaths qa warning

From: Kai Kang <[email protected]>

Fix buildpaths qa warning of libidn2:

| WARNING: libidn2-2.0.5-r0 do_package_qa: QA Issue: File
| /work/core2-64-poky-linux/libidn2/2.0.5-r0/packages-split/libidn2-dev/usr/lib/pkgconfig/libidn2.pc
| in package contained reference to tmpdir [buildpaths]
---
 meta/recipes-extended/libidn/libidn2_2.0.5.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-extended/libidn/libidn2_2.0.5.bb +4 -0
index 0daf7a6877..da77c4402d 100644
@@ -26,4 +26,8 @@ EXTRA_OECONF += "--disable-rpath \
 LICENSE_${PN} = "(GPLv2+ | LGPLv3)"
 LICENSE_${PN}-bin = "GPLv3+"
 
+do_install_append () {
+    sed -i 's#${RECIPE_SYSROOT}##' ${D}${libdir}/pkgconfig/libidn2.pc
+}
+
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.20.0
#2 lore raw
In reply to [email protected]
Quoted 22 lines · On Thu, 17 Jan 2019 at 01:13, <[email protected]> wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused

by __FILE__ macro expansion for packages such as llvm and librepo.

---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/bitbake.conf +0 -0
index 0bdcd04d74..d20460e845 100644
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
 # Optimization flags.
 ##################################################################

meta/conf/bitbake.conf EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} " · line 607

Quoted 10 lines
meta/conf/bitbake.conf +3 -3
 # Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 

I like the idea of this, but it will break meta-clang until either 1)
https://reviews.llvm.org/D49466 lands, or 2) meta-clang sets its own DEBUG_PREFIX_MAP.

Quoted 8 lines

--
2.20.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
In reply to [email protected]

The commit message doesn’t match what you’re actually doing. "Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including -fmacro-prefix-map and -fdebug-prefix-map currently” I assume you mean "Specifying -ffile-prefix-map” there.

Quoted 43 lines · On Thu, Jan 17, 2019 at 12:13 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused

by __FILE__ macro expansion for packages such as llvm and librepo.

---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/bitbake.conf +0 -0
index 0bdcd04d74..d20460e845 100644
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =

"${PARALLEL_MAKEINST} "
# Optimization flags.
##################################################################
# Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \

meta/conf/bitbake.conf +1 -2
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?=

"-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \

meta/conf/bitbake.conf +2 -1
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 
--

2.20.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 4 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
#4 lore raw

You also aren’t “resetting” anything, I’d suggest clarifying the summary as well.

Quoted 59 lines · Christopher Larson

The commit message doesn’t match what you’re actually doing. "Specifying

(quoted diff) +0 -4
-fdebug-prefix-map is equivalent to specifying all the individual
-f*-prefix-map options which means including -fmacro-prefix-map and
-fdebug-prefix-map currently” I assume you mean "Specifying
-ffile-prefix-map” there.
Quoted 37 lines · On Thu, Jan 17, 2019 at 12:13 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused

by __FILE__ macro expansion for packages such as llvm and librepo.

---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/bitbake.conf +0 -0
index 0bdcd04d74..d20460e845 100644
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =

"${PARALLEL_MAKEINST} "
# Optimization flags.
##################################################################
# Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \

meta/conf/bitbake.conf +1 -2
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?=

"-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \

meta/conf/bitbake.conf +2 -1
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 
--

2.20.0

Quoted 6 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

Signature · 4 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
author
#5 lore raw
In reply to Christopher Larson
Quoted 1 line · Christopher Larson

The commit message doesn’t match what you’re actually doing. "Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including -fmacro-prefix-map and -fdebug-prefix-map currently” I assume you mean "Specifying -ffile-prefix-map” there.

Sorry typo here.

Regards,
Kai

Quoted 59 lines · On Thu, Jan 17, 2019 at 12:13 AM <[email protected]…
    From: Kai Kang <[email protected]
    <mailto:[email protected]>>

    Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
    Specifying -fdebug-prefix-map is equivalent to specifying all the
    individual -f*-prefix-map options which means including
    -fmacro-prefix-map and -fdebug-prefix-map currently. Option
    -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
    by __FILE__ macro expansion for packages such as llvm and librepo.

    Signed-off-by: Kai Kang <[email protected]
    <mailto:[email protected]>>
    ---
     meta/conf/bitbake.conf | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
    index 0bdcd04d74..d20460e845 100644
    --- a/meta/conf/bitbake.conf
    +++ b/meta/conf/bitbake.conf
    @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =
    "${PARALLEL_MAKEINST} "
     # Optimization flags.
     ##################################################################
     # Beware: applied last to first
    -DEBUG_PREFIX_MAP ?=
    "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}
    \
    -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
    -  -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
    +DEBUG_PREFIX_MAP ?=
    "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}
    \
    +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
    +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
     "
     DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types
    ${DEBUG_PREFIX_MAP}"

    -- 
    2.20.0

    -- 
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 4 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
Signature · 1 line
Kai Kang
#6 lore raw
In reply to [email protected]
Quoted 9 lines · On Thu, 2019-01-17 at 02:12 -0500, [email protected] wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused

by __FILE__ macro expansion for packages such as llvm and librepo.

Quoted 4 lines
---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

I like the idea of the patch a lot. Unfortunately it causes an oe- selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/131

in the go toolchain.

oe-selftest -r gotoolchain.oeGoToolchainSelfTest.test_go_dep_build

should reproduce.

Cheers,

Richard

#7 lore raw
Quoted 19 lines · Richard Purdie
Quoted 10 lines · On Thu, 2019-01-17 at 02:12 -0500, [email protected] wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which

caused
by __FILE__ macro expansion for packages such as llvm and librepo.

Quoted 4 lines
---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

I like the idea of the patch a lot. Unfortunately it causes an oe- selftest failure:

Quoted 7 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/131

in the go toolchain.

oe-selftest -r gotoolchain.oeGoToolchainSelfTest.test_go_dep_build

should reproduce.

There does appear to be another issue:

http://git.yoctoproject.org/cgit.cgi/poky-buildhistory/commit/?h=poky/master-next/qemux86&id=e3195d9809716652546a1ac69a75287ec707e79b

The debug src files appear to be disappearing?

Cheers,

Richard

#8 lore raw
In reply to [email protected]
Quoted 20 lines · On Wed, Jan 16, 2019 at 11:13 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'. Specifying -fdebug-prefix-map is equivalent to specifying all the individual -f*-prefix-map options which means including

(quoted diff) +0 -2
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused

by __FILE__ macro expansion for packages such as llvm and librepo.

---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/bitbake.conf +0 -0
index 0bdcd04d74..d20460e845 100644

meta/conf/bitbake.conf EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} " · line 604

Quoted 9 lines
meta/conf/bitbake.conf +3 -3
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
 # Optimization flags.
 ##################################################################
 # Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

Quoted 11 lines
meta/conf/bitbake.conf +0 -1
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 
--

2.20.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#9 lore raw
Quoted 2 lines · Khem Raj

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

Ross

#10 lore raw
Quoted 10 lines · Ross
Quoted 2 lines · Khem Raj

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

yes it can, but one by one there are many changes to keep and core becomes tied to gcc. We should be conscious about it.

Quoted 2 lines

Ross

author
#11 lore raw
Quoted 11 lines · Khem Raj
Quoted 8 lines · Ross
Quoted 2 lines · Khem Raj

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

yes it can, but one by one there are many changes to keep and core becomes tied to gcc. We should be conscious about it.

From the link https://reviews.llvm.org/D49466 pasted by Dan, we know that clang will support option '-ffile-prefix-map'. I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when clang support for '-ffile-prefix-map' implemented.

Regards,
Kai

Quoted 2 lines
Quoted 2 lines

Ross

Signature · 1 line
Kai Kang
#12 lore raw
Quoted 11 lines · Kang Kai
Quoted 9 lines · Khem Raj
Quoted 8 lines · Ross
Quoted 2 lines · Khem Raj

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

Quoted 8 lines
Quoted 2 lines

yes it can, but one by one there are many changes to keep and core becomes tied to gcc. We should be conscious about it.

From the link https://reviews.llvm.org/D49466 pasted by Dan, we know
that clang will support option '-ffile-prefix-map'.
I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when clang support for '-ffile-prefix-map' implemented.

Thats ok, not worried about clang at this point. But the patch itself was not working last time on gcc either. So if that is fixed we can consider it.

Quoted 12 lines

Regards,
Kai

Quoted 2 lines
Quoted 2 lines

Ross

--
Kai Kang

author
#13 lore raw
Quoted 14 lines · Khem Raj
Quoted 13 lines · Kang Kai
Quoted 11 lines · Khem Raj
Quoted 8 lines · Ross
Quoted 2 lines · Khem Raj

I am bit concerned about using -ffile-prefix-map here, its gcc only option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

yes it can, but one by one there are many changes to keep and core becomes tied to gcc. We should be conscious about it.

Quoted 6 lines
Quoted 4 lines

From the link https://reviews.llvm.org/D49466 pasted by Dan, we know
that clang will support option '-ffile-prefix-map'.
I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when clang support for '-ffile-prefix-map' implemented.

Thats ok, not worried about clang at this point. But the patch itself was not working last time on gcc either. So if that is fixed we can consider it.

OK. I am working on the issued pointed by Richard.

Quoted 10 lines
Quoted 10 lines

Regards,
Kai

Quoted 1 line
Quoted 1 line

Ross

--
Kai Kang

Signature · 1 line
Kai Kang