xen: make grant table configurable
RFC PATCH 1/1 xen: make grant table configurable
Introduce CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.
---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.
RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
--- xen/arch/arm/setup.c | 3 ++- xen/arch/arm/traps.c | 2 ++ xen/arch/x86/hvm/Makefile | 2 +- xen/arch/x86/hvm/hypercall.c | 4 ++++ xen/arch/x86/hypercall.c | 2 ++ xen/arch/x86/pv/Makefile | 2 +- xen/arch/x86/pv/hypercall.c | 2 ++ xen/arch/x86/setup.c | 6 +++-- xen/common/Kconfig | 11 +++++++++ xen/common/Makefile | 2 +- xen/include/asm-arm/grant_table.h | 4 +++- xen/include/xen/grant_table.h | 49 +++++++++++++++++++++++++++++++++++++-- 12 files changed, 80 insertions(+), 9 deletions(-)
xen/arch/arm/setup.c +2 -1
@@ -740,7 +740,8 @@ void __init start_xen(unsigned long boot_phys_offset, .flags = XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, .max_grant_frames = gnttab_dom0_frames(), - .max_maptrack_frames = opt_max_maptrack_frames, + .max_maptrack_frames = IS_ENABLED(CONFIG_GRANT_TABLE) ? + opt_max_maptrack_frames : 0, }; dcache_line_bytes =read_dcache_line_bytes ();
xen/arch/arm/traps.c +2 -0
@@ -1392,7 +1392,9 @@ static arm_hypercall_t arm_hypercall_table[] = {HYPERCALL_DEPRECATED (physdev_op_compat,1 ),HYPERCALL (sysctl,2 ),HYPERCALL (hvm_op,2 ), +#ifdef CONFIG_GRANT_TABLEHYPERCALL (grant_table_op,3 ), +#endifHYPERCALL (multicall,2 ),HYPERCALL (platform_op,1 ), HYPERCALL_ARM(vcpu_op, 3),
xen/arch/x86/hvm/Makefile +1 -1
@@ -7,7 +7,7 @@ obj-y += dm.o obj-bin-y += dom0_build.init.o obj-y += domain.o obj-y += emulate.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += hpet.o obj-y += hvm.o obj-y += hypercall.o
xen/arch/x86/hvm/hypercall.c +4 -0
@@ -47,6 +47,7 @@ static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)return rc; } +#ifdef CONFIG_GRANT_TABLE static long hvm_grant_table_op (unsigned int cmd,XEN_GUEST_HANDLE_PARAM (void ) uop,unsigned int count) {
@@ -71,6 +72,7 @@ static long hvm_grant_table_op( else return compat_grant_table_op(cmd, uop, count); } +#endif static long hvm_physdev_op (int cmd,XEN_GUEST_HANDLE_PARAM (void ) arg) {
@@ -119,7 +121,9 @@ static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)static const hypercall_table_t hvm_hypercall_table[] = {HVM_CALL (memory_op), +#ifdef CONFIG_GRANT_TABLEHVM_CALL (grant_table_op), +#endifCOMPAT_CALL (vcpu_op),HVM_CALL (physdev_op),COMPAT_CALL (xen_version),
xen/arch/x86/hypercall.c +2 -0
@@ -47,7 +47,9 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] =ARGS (xen_version,2 ),ARGS (console_io,3 ),ARGS (physdev_op_compat,1 ), +#ifdef CONFIG_GRANT_TABLEARGS (grant_table_op,3 ), +#endifARGS (vm_assist,2 ),COMP (update_va_mapping_otherdomain,4 ,5 ), ARGS(vcpu_op, 3),
xen/arch/x86/pv/Makefile +1 -1
@@ -5,7 +5,7 @@ obj-y += emulate.o obj-y += emul-gate-op.o obj-y += emul-inv-op.o obj-y += emul-priv-op.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += hypercall.o obj-y += iret.o obj-y += misc-hypercalls.o
xen/arch/x86/pv/hypercall.c +2 -0
@@ -53,7 +53,9 @@ const hypercall_table_t pv_hypercall_table[] = {COMPAT_CALL (xen_version),HYPERCALL (console_io),COMPAT_CALL (physdev_op_compat), +#ifdef CONFIG_GRANT_TABLECOMPAT_CALL (grant_table_op), +#endifCOMPAT_CALL (vm_assist),COMPAT_CALL (update_va_mapping_otherdomain), COMPAT_CALL(iret),
xen/arch/x86/setup.c +4 -2
@@ -686,8 +686,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)struct xen_domctl_createdomain dom0_cfg = { .flags = XEN_DOMCTL_CDF_s3_integrity, .max_evtchn_port =-1 , - .max_grant_frames = opt_max_grant_frames, - .max_maptrack_frames = opt_max_maptrack_frames, + .max_grant_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_grant_frames :0 , + .max_maptrack_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_maptrack_frames :0 , };/* Critical region without IDT or TSS. Any fault is deadly! */
xen/common/Kconfig +11 -0
@@ -11,6 +11,17 @@ config COMPAT config CORE_PARKING bool +config GRANT_TABLE + bool "Grant table support" + default y + ---help--- + Grant table provides a generic mechanism to memory sharing + between domains. This shared memory interface underpins the + split device drivers for block and network IO in a classic + Xen setup. + + If unsure, say Y. + config HAS_ALTERNATIVE bool
xen/common/Makefile +1 -1
@@ -10,7 +10,7 @@ obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += guestcopy.o obj-bin-y += gunzip.init.o obj-y += irq.o
xen/include/asm-arm/grant_table.h +3 -1
@@ -31,7 +31,9 @@ void gnttab_mark_dirty(struct domain *d, mfn_t mfn);* enough space for a large grant table */ #define gnttab_dom0_frames () \ - min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext)) + min_t(unsigned int, \ + IS_ENABLED(CONFIG_GRANT_TABLE) ? opt_max_grant_frames : 0, \ + PFN_DOWN(_etext - _stext))#define gnttab_init_arch (gt) \ ({ \
xen/include/xen/grant_table.h +47 -2
62 lines not on this page · raw message
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 2 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.
Looks like a good idea.
Quoted 9 lines
Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
Can Gitlab do Arm hypervisor builds?
Quoted 265 lines
--- xen/arch/arm/setup.c | 3 ++- xen/arch/arm/traps.c | 2 ++ xen/arch/x86/hvm/Makefile | 2 +- xen/arch/x86/hvm/hypercall.c | 4 ++++ xen/arch/x86/hypercall.c | 2 ++ xen/arch/x86/pv/Makefile | 2 +- xen/arch/x86/pv/hypercall.c | 2 ++ xen/arch/x86/setup.c | 6 +++-- xen/common/Kconfig | 11 +++++++++ xen/common/Makefile | 2 +- xen/include/asm-arm/grant_table.h | 4 +++- xen/include/xen/grant_table.h | 49 +++++++++++++++++++++++++++++++++++++-- 12 files changed, 80 insertions(+), 9 deletions(-)xen/arch/arm/setup.c +2
-1@@ -740,7 +740,8 @@ void __init start_xen(unsigned long boot_phys_offset, .flags = XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, .max_grant_frames = gnttab_dom0_frames(), - .max_maptrack_frames = opt_max_maptrack_frames, + .max_maptrack_frames = IS_ENABLED(CONFIG_GRANT_TABLE) ? + opt_max_maptrack_frames : 0, }; dcache_line_bytes =read_dcache_line_bytes ();xen/arch/arm/traps.c +2
-0@@ -1392,7 +1392,9 @@ static arm_hypercall_t arm_hypercall_table[] = {HYPERCALL_DEPRECATED (physdev_op_compat,1 ),HYPERCALL (sysctl,2 ),HYPERCALL (hvm_op,2 ), +#ifdef CONFIG_GRANT_TABLEHYPERCALL (grant_table_op,3 ), +#endifHYPERCALL (multicall,2 ),HYPERCALL (platform_op,1 ), HYPERCALL_ARM(vcpu_op, 3),xen/arch/x86/hvm/Makefile +1
-1@@ -7,7 +7,7 @@ obj-y += dm.o obj-bin-y += dom0_build.init.o obj-y += domain.o obj-y += emulate.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += hpet.o obj-y += hvm.o obj-y += hypercall.oxen/arch/x86/hvm/hypercall.c +4
-0@@ -47,6 +47,7 @@ static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)return rc; } +#ifdef CONFIG_GRANT_TABLE static long hvm_grant_table_op (unsigned int cmd,XEN_GUEST_HANDLE_PARAM (void ) uop,unsigned int count) {@@ -71,6 +72,7 @@ static long hvm_grant_table_op( else return compat_grant_table_op(cmd, uop, count); } +#endif static long hvm_physdev_op (int cmd,XEN_GUEST_HANDLE_PARAM (void ) arg) {@@ -119,7 +121,9 @@ static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)static const hypercall_table_t hvm_hypercall_table[] = {HVM_CALL (memory_op), +#ifdef CONFIG_GRANT_TABLEHVM_CALL (grant_table_op), +#endifCOMPAT_CALL (vcpu_op),HVM_CALL (physdev_op),COMPAT_CALL (xen_version),xen/arch/x86/hypercall.c +2
-0@@ -47,7 +47,9 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] =ARGS (xen_version,2 ),ARGS (console_io,3 ),ARGS (physdev_op_compat,1 ), +#ifdef CONFIG_GRANT_TABLEARGS (grant_table_op,3 ), +#endifARGS (vm_assist,2 ),COMP (update_va_mapping_otherdomain,4 ,5 ), ARGS(vcpu_op, 3),xen/arch/x86/pv/Makefile +1
-1@@ -5,7 +5,7 @@ obj-y += emulate.o obj-y += emul-gate-op.o obj-y += emul-inv-op.o obj-y += emul-priv-op.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += hypercall.o obj-y += iret.o obj-y += misc-hypercalls.oxen/arch/x86/pv/hypercall.c +2
-0@@ -53,7 +53,9 @@ const hypercall_table_t pv_hypercall_table[] = {COMPAT_CALL (xen_version),HYPERCALL (console_io),COMPAT_CALL (physdev_op_compat), +#ifdef CONFIG_GRANT_TABLECOMPAT_CALL (grant_table_op), +#endifCOMPAT_CALL (vm_assist),COMPAT_CALL (update_va_mapping_otherdomain), COMPAT_CALL(iret),xen/arch/x86/setup.c +4
-2@@ -686,8 +686,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)struct xen_domctl_createdomain dom0_cfg = { .flags = XEN_DOMCTL_CDF_s3_integrity, .max_evtchn_port =-1 , - .max_grant_frames = opt_max_grant_frames, - .max_maptrack_frames = opt_max_maptrack_frames, + .max_grant_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_grant_frames :0 , + .max_maptrack_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_maptrack_frames :0 , };/* Critical region without IDT or TSS. Any fault is deadly! */ xen/common/Kconfig +11
-0@@ -11,6 +11,17 @@ config COMPAT config CORE_PARKING bool +config GRANT_TABLE + bool "Grant table support" + default y + ---help--- + Grant table provides a generic mechanism to memory sharing + between domains. This shared memory interface underpins the + split device drivers for block and network IO in a classic + Xen setup. + + If unsure, say Y. + config HAS_ALTERNATIVE boolxen/common/Makefile +1
-1@@ -10,7 +10,7 @@ obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o -obj-y += grant_table.o +obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += guestcopy.o obj-bin-y += gunzip.init.o obj-y += irq.oxen/include/asm-arm/grant_table.h +3
-1@@ -31,7 +31,9 @@ void gnttab_mark_dirty(struct domain *d, mfn_t mfn);* enough space for a large grant table */ #define gnttab_dom0_frames () \ - min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext)) + min_t(unsigned int, \ + IS_ENABLED(CONFIG_GRANT_TABLE) ? opt_max_grant_frames : 0, \ + PFN_DOWN(_etext - _stext))#define gnttab_init_arch (gt) \ ({ \xen/include/xen/grant_table.h +47
-2@@ -29,11 +29,12 @@#include <asm/page.h> #include <asm/grant_table.h> -struct grant_table ; -extern unsigned int opt_max_grant_frames;extern unsigned int opt_max_maptrack_frames; +#ifdef CONFIG_GRANT_TABLE +struct grant_table ; +/* Create/destroy per-domain grant table context. */ int grant_table_init (struct domain *d,unsigned int max_grant_frames,unsigned int max_maptrack_frames);@@ -61,4 +62,48 @@ int gnttab_get_shared_frame(struct domain *d, unsigned long idx,int gnttab_get_status_frame (struct domain *d,unsigned long idx,mfn_t *mfn); +#else + +static inline int grant_table_init (struct domain *d, +unsigned int max_grant_frames, +unsigned int max_maptrack_frames) +{ +return 0 ; +} + +static inline void grant_table_destroy (struct domain *d) {} + +static inline void grant_table_init_vcpu (struct vcpu *v) {} + +static inline void grant_table_warn_active_grants (struct domain *d) {} + +static inline void gnttab_release_mappings (struct domain *d) {} + +static inline int mem_sharing_gref_to_gfn (struct grant_table *gt, +grant_ref_t ref, +gfn_t *gfn,uint16_t *status) +{ +return -EINVAL ; +} + +static inline int gnttab_map_frame (struct domain *d,unsigned long idx, +gfn_t gfn,mfn_t *mfn) +{ +return -EINVAL ; +} + +static inline int gnttab_get_shared_frame (struct domain *d,unsigned long idx, +mfn_t *mfn) +{ +return -EINVAL ; +} + +static inline int gnttab_get_status_frame (struct domain *d,unsigned long idx, +mfn_t *mfn) +{ +return -EINVAL ; +} + +#endif /* CONFIG_GRANT_TABLE */ +#endif /* __XEN_GRANT_TABLE_H__ */ Signature · 1 line
2.11.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 12 lines · Stefano Stabellini
Quoted 2 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.Looks like a good idea.
Quoted 5 lines
Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.
Quoted 6 lines
Quoted 4 lines
RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
Can Gitlab do Arm hypervisor builds?
Yes. I hooked up a box from WorksOnArm for Arm64 builds.
Wei.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 13 lines · Wei Liu
Quoted 12 lines · Stefano Stabellini
Quoted 2 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.Looks like a good idea.
Quoted 5 lines
Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
Can Gitlab do Arm hypervisor builds?
Yes. I hooked up a box from WorksOnArm for Arm64 builds.
Very nice!! You should write a blog post or something about it.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Yes! I'd love to hear more about what you did, to help me further promote Xen as a Works on Arm supported project. Also, I'd love to hear more details about the Gitlab integration, as I am working diligently to get arm64 support into their mainline roadmap.
thanks
Ed
Quoted 19 lines · Stefano Stabellini
Quoted 18 lines · Wei Liu
Quoted 17 lines · Stefano Stabellini
Quoted 2 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.Looks like a good idea.
Quoted 9 lines
Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Can Gitlab do Arm hypervisor builds?
Yes. I hooked up a box from WorksOnArm for Arm64 builds.
Very nice!! You should write a blog post or something about it.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 32 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
--- xen/arch/arm/setup.c | 3 ++- xen/arch/arm/traps.c | 2 ++ xen/arch/x86/hvm/Makefile | 2 +- xen/arch/x86/hvm/hypercall.c | 4 ++++ xen/arch/x86/hypercall.c | 2 ++ xen/arch/x86/pv/Makefile | 2 +- xen/arch/x86/pv/hypercall.c | 2 ++ xen/arch/x86/setup.c | 6 +++-- xen/common/Kconfig | 11 +++++++++ xen/common/Makefile | 2 +- xen/include/asm-arm/grant_table.h | 4 +++- xen/include/xen/grant_table.h | 49 +++++++++++++++++++++++++++++++++++++-- 12 files changed, 80 insertions(+), 9 deletions(-)xen/arch/arm/setup.c +0
-0
xen/arch/arm/setup.c void __init start_xen(unsigned long boot_phys_offset, · line 744
Quoted 6 lines
xen/arch/arm/setup.c +2
-1@@ -740,7 +740,8 @@ void __init start_xen(unsigned long boot_phys_offset, .flags = XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, .max_grant_frames = gnttab_dom0_frames(), - .max_maptrack_frames = opt_max_maptrack_frames, + .max_maptrack_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_maptrack_frames : 0,
You can remove this conditional logic by adding #define opt_max_grant_frames 0 in the stubs in grant_table.h
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 28 lines · Andrew Cooper
Quoted 27 lines · Wei Liu
Introduce
CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm hypervisors build with grant table disabled.Signed-off-by Wei Liu <[email protected]>---
I did this when I worked on splitting PV and HVM and thought this might be useful and it was simple enough to get done.RFC because I can envisage some configurations in the distant future do away with grant table and event channel. There is small a benefit to consider accepting this patch now so that Gitlab's randconf build can start testing with grant table turned off right away.
--- xen/arch/arm/setup.c | 3 ++- xen/arch/arm/traps.c | 2 ++ xen/arch/x86/hvm/Makefile | 2 +- xen/arch/x86/hvm/hypercall.c | 4 ++++ xen/arch/x86/hypercall.c | 2 ++ xen/arch/x86/pv/Makefile | 2 +- xen/arch/x86/pv/hypercall.c | 2 ++ xen/arch/x86/setup.c | 6 +++-- xen/common/Kconfig | 11 +++++++++ xen/common/Makefile | 2 +- xen/include/asm-arm/grant_table.h | 4 +++- xen/include/xen/grant_table.h | 49 +++++++++++++++++++++++++++++++++++++-- 12 files changed, 80 insertions(+), 9 deletions(-)
Quoted 15 lines
xen/arch/arm/setup.c void __init start_xen(unsigned long boot_phys_offset, · line 744
Quoted 11 lines
xen/arch/arm/setup.c +2
-1@@ -740,7 +740,8 @@ void __init start_xen(unsigned long boot_phys_offset, .flags = XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, .max_grant_frames = gnttab_dom0_frames(), - .max_maptrack_frames = opt_max_maptrack_frames, + .max_maptrack_frames =IS_ENABLED (CONFIG_GRANT_TABLE ) ? + opt_max_maptrack_frames : 0,You can remove this conditional logic by adding #define
opt_max_grant_frames0 in the stubs ingrant_table.h
Ack.
Wei.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.01.19 at 13:30, <[email protected]> wrote:
xen/common/Kconfig +0
-0@@ -11,6 +11,17 @@ config COMPAT config CORE_PARKING
xen/common/Kconfig config COMPAT · line 21
Quoted 10 lines
xen/common/Kconfig +8
-0bool +config GRANT_TABLE + bool "Grant table support" + default y + ---help--- + Grant table provides a generic mechanism to memory sharing + between domains. This shared memory interface underpins the + split device drivers for block and network IO in a classic + Xen setup.
I can see reasons why one may want this (along the lines of SILO mode), but it'll produce an entirely ABI-incompatible hypervisor. Most front-/backend driver pairs won't work without it. I'm not sure the tool stack is prepared to act on such a hypervisor. I'm pretty sure at least XenoLinux derivatives BUG() upon error returns from certain gnttab hypercalls.
As such as well as to be within our general line of what Kconfig options we permit, I think for the time being the prompt needs to depend on EXPERT = "y".
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 23 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.01.19 at 13:30, <[email protected]> wrote:
xen/common/Kconfig +0
-0@@ -11,6 +11,17 @@ config COMPAT config CORE_PARKINGxen/common/Kconfig config COMPAT · line 21
Quoted 10 lines
xen/common/Kconfig +8
-0bool +config GRANT_TABLE + bool "Grant table support" + default y + ---help--- + Grant table provides a generic mechanism to memory sharing + between domains. This shared memory interface underpins the + split device drivers for block and network IO in a classic + Xen setup.I can see reasons why one may want this (along the lines of SILO mode), but it'll produce an entirely ABI-incompatible hypervisor. Most front-/backend driver pairs won't work without it. I'm not sure the tool stack is prepared to act on such a hypervisor. I'm pretty sure at least XenoLinux derivatives
BUG()upon error returns from certain gnttab hypercalls.
Quoted 3 lines
As such as well as to be within our general line of what
Kconfigoptions we permit, I think for the time being the prompt needs to depend on EXPERT = "y".
Good point. I will do that.
Wei.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel