Skip to contentSkip to conversation

leds: fix regression in usbport led trigger

PATCH Superseded Greg Kroah-Hartman 1 participant 1 message Jan 18, 2019 USB

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH v2 1/1 leds: fix regression in usbport led trigger

Quoted 6 lines · Christian Lamparter

The patch "usb: simplify usbport trigger" together with "leds: triggers:
add device attribute support" caused an regression for the usbport trigger. it will no longer enumerate any active usb hub ports under the "ports" directory in the sysfs class directory, if the usb host drivers are fully initialized before the usbport trigger was loaded.

Quoted 8 lines

The reason is that the usbport driver tries to register the sysfs entries during the activate() callback. And this will fail with -2 / ENOENT because the patch "leds: triggers: add device attribute support" made it so that the sysfs "ports" group was only being added after the activate() callback succeeded.

This version of the patch reverts parts of the "usb: simplify usbport trigger" patch and restores usbport trigger's functionality.

This feels like going backwards, as a driver should not be adding and removing sysfs groups, because you race with userspace. Userspace has no idea that the new sysfs files were added or removed, right?

I'll apply this, but this feels like a problem in the led api if the above really is true.

also, please wrap your changelogs at 72 columns, making it easier to read. I did that here for you...

thanks,

greg k-h