Skip to contentSkip to conversation

drm: fix drm_can_sleep() comment

PATCH In review Sam Ravnborg 2 participants 2 messages Jan 20, 2019 – Jan 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: fix drm_can_sleep() comment

Reversed logic when writing the original comment, now fixed.

Fixes e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
Cc Laurent Pinchart <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 include/drm/drm_util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_util.h +1 -1
index 8163d35f8327..07b8e9f04599 100644
@@ -71,7 +71,7 @@
  * FIXME: All users of drm_can_sleep should be removed (see todo.rst)
  *
  * Returns:
- * True if kgdb is active or we are in an atomic context or irqs are disabled
+ * False if kgdb is active, we are in atomic context or irqs are disabled.
  */
 static inline bool drm_can_sleep(void)
 {
Signature · 6 lines
2.12.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 11 lines · Sam Ravnborg

Reversed logic when writing the original comment, now fixed.

Fixes e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
Cc Laurent Pinchart <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>

Thanks, merged.
-Daniel

Quoted 20 lines
---
 include/drm/drm_util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_util.h +1 -1
index 8163d35f8327..07b8e9f04599 100644
@@ -71,7 +71,7 @@
  * FIXME: All users of drm_can_sleep should be removed (see todo.rst)
  *
  * Returns:
- * True if kgdb is active or we are in an atomic context or irqs are disabled
+ * False if kgdb is active, we are in atomic context or irqs are disabled.
  */
 static inline bool drm_can_sleep(void)
 {
Signature · 1 line
2.12.0
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel