Compiler warnings series
cover Compiler warnings series
A short series of compiler visibility warning fixes that I prepared whilst trialing improvements to xf86-video-nouveau's use of the core xorg-server utility macros.
Rhys Kidd (4):
wfb: Remove declaration for undefined function nouveau_wfb_init()
dri2: Mark local create/destroy buffer and copy region functions as
static
xv: Mark local NVSetupTexturedVideo function as static xv/nv30,nv40: Mark local NV30GetSurfaceFormat and NV40GetSurfaceFormat
as static
src/nouveau_dri2.c | 12 ++++++------ src/nouveau_xv.c | 2 +- src/nv30_xv_tex.c | 2 +- src/nv40_xv_tex.c | 2 +- src/nv_proto.h | 1 - 5 files changed, 9 insertions(+), 10 deletions(-)
Signature · 6 lines
2.19.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
A message that is not in the archive (sent off-list or not yet received): 20190121032134.6492-1-rhyskidd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
PATCH 1/4 wfb: Remove declaration for undefined function nouveau_wfb_init()
--- src/nv_proto.h | 1 - 1 file changed, 1 deletion(-)
src/nv_proto.h +0 -1
@@ -61,7 +61,6 @@ Bool NVAccelM2MF(NVPtr pNv, int w, int h, int cpp, uint32_t srco, uint32_t dsto,void nouveau_wfb_setup_wrap (ReadMemoryProcPtr *,WriteMemoryProcPtr *,DrawablePtr );void nouveau_wfb_finish_wrap (DrawablePtr ); -void nouveau_wfb_init ();/* in nv_shadow.c */ void NVRefreshArea (ScrnInfoPtr pScrn,int num,BoxPtr pbox);
Signature · 6 lines
2.19.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
PATCH 2/4 dri2: Mark local create/destroy buffer and copy region functions as static
In reply to a message not in the archiveAvoids warnings with gcc 8.2:
nouveau_dri2.c:38:1: warning: no previous prototype for ‘nouveau_dri2_create_buffer2’ [-Wmissing-prototypes]
nouveau_dri2_create_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, unsigned int attachment, ^~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:109:1: warning: no previous prototype for ‘nouveau_dri2_create_buffer’ [-Wmissing-prototypes]
nouveau_dri2_create_buffer(DrawablePtr pDraw, unsigned int attachment, ^~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:117:1: warning: no previous prototype for ‘nouveau_dri2_destroy_buffer2’ [-Wmissing-prototypes]
nouveau_dri2_destroy_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, DRI2BufferPtr buf) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:131:1: warning: no previous prototype for ‘nouveau_dri2_destroy_buffer’ [-Wmissing-prototypes]
nouveau_dri2_destroy_buffer(DrawablePtr pDraw, DRI2BufferPtr buf) ^~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:137:1: warning: no previous prototype for ‘nouveau_dri2_copy_region2’ [-Wmissing-prototypes]
nouveau_dri2_copy_region2(ScreenPtr pScreen, DrawablePtr pDraw, RegionPtr pRegion, ^~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:215:1: warning: no previous prototype for ‘nouveau_dri2_copy_region’ [-Wmissing-prototypes]
nouveau_dri2_copy_region(DrawablePtr pDraw, RegionPtr pRegion,
^~~~~~~~~~~~~~~~~~~~~~~~
--- src/nouveau_dri2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
src/nouveau_dri2.c +6 -6
@@ -34,7 +34,7 @@ static PixmapPtr get_drawable_pixmap(DrawablePtr drawable)return (*drawable->pScreen->GetWindowPixmap)((WindowPtr )drawable); } -DRI2BufferPtr +static DRI2BufferPtr nouveau_dri2_create_buffer2 (ScreenPtr pScreen,DrawablePtr pDraw,unsigned int attachment,unsigned int format) {
@@ -105,7 +105,7 @@ nouveau_dri2_create_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, unsigned int areturn &nvbuf->base; } -DRI2BufferPtr +static DRI2BufferPtr nouveau_dri2_create_buffer (DrawablePtr pDraw,unsigned int attachment,unsigned int format) {
@@ -113,7 +113,7 @@ nouveau_dri2_create_buffer(DrawablePtr pDraw, unsigned int attachment, attachment, format); } -void +static void nouveau_dri2_destroy_buffer2 (ScreenPtr pScreen,DrawablePtr pDraw,DRI2BufferPtr buf) {struct nouveau_dri2_buffer *nvbuf;
@@ -127,13 +127,13 @@ nouveau_dri2_destroy_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, DRI2BufferPtrfree (nvbuf); } -void +static void nouveau_dri2_destroy_buffer (DrawablePtr pDraw,DRI2BufferPtr buf) {nouveau_dri2_destroy_buffer2 (pDraw->pScreen, pDraw, buf); } -void +static void nouveau_dri2_copy_region2 (ScreenPtr pScreen,DrawablePtr pDraw,RegionPtr pRegion,DRI2BufferPtr pDstBuffer,DRI2BufferPtr pSrcBuffer) {
@@ -211,7 +211,7 @@ nouveau_dri2_copy_region2(ScreenPtr pScreen, DrawablePtr pDraw, RegionPtr pRegioFreeScratchGC (pGC); } -void +static void nouveau_dri2_copy_region (DrawablePtr pDraw,RegionPtr pRegion,DRI2BufferPtr pDstBuffer,DRI2BufferPtr pSrcBuffer) {
Signature · 6 lines
2.19.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
PATCH 3/4 xv: Mark local NVSetupTexturedVideo function as static
In reply to a message not in the archiveAvoids warning with gcc 8.2:
nouveau_xv.c:2136:1: warning: no previous prototype for ‘NVSetupTexturedVideo’ [-Wmissing-prototypes]
NVSetupTexturedVideo (ScreenPtr pScreen, XF86VideoAdaptorPtr *textureAdaptor) ^~~~~~~~~~~~~~~~~~~~
--- src/nouveau_xv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/nouveau_xv.c +1 -1
@@ -2131,7 +2131,7 @@ NV50SetupTexturedVideo (ScreenPtr pScreen)return adapt; } -void +static void NVSetupTexturedVideo (ScreenPtr pScreen,XF86VideoAdaptorPtr *textureAdaptor) {ScrnInfoPtr pScrn =xf86ScreenToScrn (pScreen);
Signature · 6 lines
2.19.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
PATCH 4/4 xv/nv30, nv40: Mark local NV30GetSurfaceFormat and NV40GetSurfaceFormat as static
In reply to a message not in the archiveAvoids warnings with gcc 8.2:
nv30_xv_tex.c:138:1: warning: no previous prototype for ‘NV30GetSurfaceFormat’ [-Wmissing-prototypes]
NV30GetSurfaceFormat(PixmapPtr ppix, int *fmt_ret)
^~~~~~~~~~~~~~~~~~~~
nv40_xv_tex.c:138:1: warning: no previous prototype for ‘NV40GetSurfaceFormat’ [-Wmissing-prototypes]
NV40GetSurfaceFormat(PixmapPtr ppix, int *fmt_ret)
^~~~~~~~~~~~~~~~~~~~
--- src/nv30_xv_tex.c | 2 +- src/nv40_xv_tex.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
src/nv30_xv_tex.c +1 -1
@@ -134,7 +134,7 @@ NV30VideoTexture(ScrnInfoPtr pScrn, struct nouveau_bo *src, int offset,return TRUE; } -Bool +static Bool NV30GetSurfaceFormat (PixmapPtr ppix,int *fmt_ret) {switch (ppix->drawable.bitsPerPixel) {
src/nv40_xv_tex.c +1 -1
@@ -134,7 +134,7 @@ NV40VideoTexture(ScrnInfoPtr pScrn, struct nouveau_bo *src, int offset,return TRUE; } -Bool +static Bool NV40GetSurfaceFormat (PixmapPtr ppix,int *fmt_ret) {switch (ppix->drawable.bitsPerPixel) {
Signature · 6 lines
2.19.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
Thanks, series applied.
Quoted 20 lines · Rhys Kidd
A short series of compiler visibility warning fixes that I prepared whilst trialing improvements to xf86-video-nouveau's use of the core xorg-server utility macros.
Rhys Kidd (4):
wfb: Remove declaration for undefined functionnouveau_wfb_init()
dri2: Mark local create/destroy buffer and copy region functions as
static
xv: Mark local NVSetupTexturedVideo function as static xv/nv30,nv40: Mark local NV30GetSurfaceFormat and NV40GetSurfaceFormat
as staticsrc/nouveau_dri2.c | 12 ++++++------ src/nouveau_xv.c | 2 +- src/nv30_xv_tex.c | 2 +- src/nv40_xv_tex.c | 2 +- src/nv_proto.h | 1 - 5 files changed, 9 insertions(+), 10 deletions(-)
Quoted 7 lines
--
2.19.1_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau