iwlwifi: fw: no need to check return value of debugfs_create functions
PATCH 1/1 iwlwifi: fw: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Johannes Berg <[email protected]>
Cc Emmanuel Grumbach <[email protected]>
Cc Luca Coelho <[email protected]>
Cc Intel Linux Wireless <[email protected]>
Cc Kalle Valo <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/fw/debugfs.c | 11 +++-------- drivers/net/wireless/intel/iwlwifi/fw/debugfs.h | 9 +++------ 2 files changed, 6 insertions(+), 14 deletions(-)
drivers/net/wireless/intel/iwlwifi/fw/debugfs.c +3 -8
@@ -173,9 +173,8 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ _FWRT_DEBUGFS_READ_WRITE_FILE_OPS(name, bufsz, struct iwl_fw_runtime)#define FWRT_DEBUGFS_ADD_FILE_ALIAS (alias, name, parent, mode) do { \ - if (!debugfs_create_file(alias, mode, parent, fwrt, \ - &iwl_dbgfs_##name##_ops)) \ - goto err; \ + debugfs_create_file(alias, mode, parent, fwrt, \ + &iwl_dbgfs_##name##_ops); \ } while (0)#define FWRT_DEBUGFS_ADD_FILE (name, parent, mode) \ FWRT_DEBUGFS_ADD_FILE_ALIAS(#name, name, parent, mode)
@@ -321,14 +320,10 @@ static ssize_t iwl_dbgfs_send_hcmd_write(struct iwl_fw_runtime *fwrt, char *buf,FWRT_DEBUGFS_WRITE_FILE_OPS (send_hcmd,512 ); -int iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt, +void iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt,struct dentry *dbgfs_dir) {INIT_DELAYED_WORK (&fwrt->timestamp.wk, iwl_fw_timestamp_marker_wk);FWRT_DEBUGFS_ADD_FILE (timestamp_marker, dbgfs_dir,0200 );FWRT_DEBUGFS_ADD_FILE (send_hcmd, dbgfs_dir,0200 ); -return 0 ; -err: -IWL_ERR (fwrt,"Can't create the fwrt debugfs directory\n" ); -return -ENOMEM ; }
drivers/net/wireless/intel/iwlwifi/fw/debugfs.h +3 -6
@@ -63,14 +63,11 @@#include "runtime.h" #ifdef CONFIG_IWLWIFI_DEBUGFS -int iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt, +void iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt,struct dentry *dbgfs_dir);#else -static inline int iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt, -struct dentry *dbgfs_dir) -{ -return 0 ; -} +static inline void iwl_fwrt_dbgfs_register (struct iwl_fw_runtime *fwrt, +struct dentry *dbgfs_dir) { }#endif /* CONFIG_IWLWIFI_DEBUGFS */
Signature · 1 line
2.20.1
Quoted 5 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should
never do something different based on this.
Quoted 8 lines
Cc Johannes Berg <[email protected]>Cc Emmanuel Grumbach <[email protected]>Cc Luca Coelho <[email protected]>Cc Intel Linux Wireless <[email protected]>Cc Kalle Valo <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>---
Thanks, Greg! I applied this in our internal tree and it will reach upstream following our normal upstreaming process.
--
Cheers,
Luca.