iwlwifi: iwl-drv: no need to check return value of debugfs_create functions
PATCH 1/1 iwlwifi: iwl-drv: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Johannes Berg <[email protected]>
Cc Emmanuel Grumbach <[email protected]>
Cc Luca Coelho <[email protected]>
Cc Intel Linux Wireless <[email protected]>
Cc Kalle Valo <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 22 -------------------- 1 file changed, 22 deletions(-)
drivers/net/wireless/intel/iwlwifi/iwl-drv.c +0 -22
@@ -1207,11 +1207,6 @@ _iwl_op_mode_start(struct iwl_drv *drv, struct iwlwifi_opmode_table *op)#ifdef CONFIG_IWLWIFI_DEBUGFS drv->dbgfs_op_mode =debugfs_create_dir (op->name, drv->dbgfs_drv); -if (!drv->dbgfs_op_mode) { -IWL_ERR (drv, -"failed to create opmode debugfs directory\n" ); -return op_mode; - } dbgfs_dir = drv->dbgfs_op_mode;#endif
@@ -1574,20 +1569,8 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) drv->dbgfs_drv =debugfs_create_dir (dev_name (trans->dev), iwl_dbgfs_root); -if (!drv->dbgfs_drv) { -IWL_ERR (drv,"failed to create debugfs directory\n" ); - ret = -ENOMEM ; - goto err_free_tlv; - } -/* Create transport layer debugfs dir */ drv->trans->dbgfs_dir =debugfs_create_dir ("trans" , drv->dbgfs_drv); - -if (!drv->trans->dbgfs_dir) { -IWL_ERR (drv,"failed to create transport debugfs directory\n" ); - ret = -ENOMEM ; - goto err_free_dbgfs; - }#endif ret =iwl_request_firmware (drv, true);
@@ -1600,9 +1583,7 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) err_fw:#ifdef CONFIG_IWLWIFI_DEBUGFS -err_free_dbgfs:debugfs_remove_recursive (drv->dbgfs_drv); -err_free_tlv:iwl_fw_dbg_free (drv->trans);#endif kfree (drv);
@@ -1713,9 +1694,6 @@ static int __init iwl_drv_init(void)#ifdef CONFIG_IWLWIFI_DEBUGFS /* Create the root of iwlwifi debugfs subsystem. */ iwl_dbgfs_root =debugfs_create_dir (DRV_NAME ,NULL ); - -if (!iwl_dbgfs_root) -return -EFAULT ;#endif return iwl_pci_register_driver ();
Signature · 1 line
2.20.1
Quoted 5 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should
never do something different based on this.
Quoted 8 lines
Cc Johannes Berg <[email protected]>Cc Emmanuel Grumbach <[email protected]>Cc Luca Coelho <[email protected]>Cc Intel Linux Wireless <[email protected]>Cc Kalle Valo <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>---
Thanks, Greg! I applied this in our internal tree and it will reach upstream following our normal upstreaming process.
--
Cheers,
Luca.