usb: gadget: udc: net2272: Fix bitwise and boolean operations
PATCH 1/1 usb: gadget: udc: net2272: Fix bitwise and boolean operations
(!x & y) strikes again.
Fix bitwise and boolean operations by enclosing the expression:
intcsr & (1 << NET2272_PCI_IRQ)
in parentheses, before applying the boolean operator '!'.
Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this.
This issue was detected with the help of Coccinelle.
Fixes ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/usb/gadget/udc/net2272.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/net2272.c +1 -1
@@ -2083,7 +2083,7 @@ static irqreturn_t net2272_irq(int irq, void *_dev)#if defined(PLX_PCI_RDK2 )/* see if PCI int for us by checking irqstat */ intcsr =readl (dev->rdk2.fpga_base_addr +RDK2_IRQSTAT ); -if (!intcsr & (1 <<NET2272_PCI_IRQ )) { +if (!(intcsr & (1 <<NET2272_PCI_IRQ ))) {spin_unlock (&dev->lock);return IRQ_NONE ; }