broadcom: Mark expected switch fall-throughs
Subsystems (4)
PATCH 1/1 broadcom: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:6336:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:2231:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/tg3.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/tg3.c:783:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +1 -1
@@ -6335,7 +6335,7 @@ int bnx2x_set_led(struct link_params *params,*/ if (!vars->link_up)break ; -/* else: fall through */ +/* fall through */ case LED_MODE_ON : if (((params->phy[EXT_PHY1].type == PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727) ||
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +1 -1
@@ -2230,7 +2230,7 @@ int bnx2x_vf_free(struct bnx2x *bp, struct bnx2x_virtf *vf) rc =bnx2x_vf_close (bp, vf);if (rc) goto op_err; -/* Fallthrough to release resources */ +/* Fall through - to release resources */ case VF_ACQUIRED :DP (BNX2X_MSG_IOV ,"about to free resources\n" );bnx2x_vf_free_resc (bp, vf);
drivers/net/ethernet/broadcom/tg3.c +2 -2
@@ -721,7 +721,7 @@ static int tg3_ape_lock(struct tg3 *tp, int locknum)case TG3_APE_LOCK_GPIO :if (tg3_asic_rev (tp) ==ASIC_REV_5761 )return 0 ; -/* else: fall through */ +/* fall through */ case TG3_APE_LOCK_GRC :case TG3_APE_LOCK_MEM :if (!tp->pci_fn)
@@ -782,7 +782,7 @@ static void tg3_ape_unlock(struct tg3 *tp, int locknum)case TG3_APE_LOCK_GPIO :if (tg3_asic_rev (tp) ==ASIC_REV_5761 )return ; -/* else: fall through */ +/* fall through */ case TG3_APE_LOCK_GRC :case TG3_APE_LOCK_MEM :if (!tp->pci_fn)
Signature · 1 line
2.20.1
-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: 23 January 2019 13:11
To: Ariel Elior <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>; Siva Reddy Kallam <[email protected]>; Prashant Sreedharan <[email protected]>; Michael Chan <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] broadcom: Mark expected switch fall-throughs
External Email
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:6336:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:2231:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/tg3.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/broadcom/tg3.c:783:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +1 -1
@@ -6335,7 +6335,7 @@ int bnx2x_set_led(struct link_params *params,*/ if (!vars->link_up)break ; -/* else: fall through */ +/* fall through */ case LED_MODE_ON : if (((params->phy[EXT_PHY1].type == PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727) || diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index c835f6c7ecd0..c97b642e6537 100644
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +1 -1
@@ -2230,7 +2230,7 @@ int bnx2x_vf_free(struct bnx2x *bp, struct bnx2x_virtf *vf) rc =bnx2x_vf_close (bp, vf);if (rc) goto op_err; -/* Fallthrough to release resources */ +/* Fall through - to release resources */ case VF_ACQUIRED :DP (BNX2X_MSG_IOV ,"about to free resources\n" ); bnx2x_vf_free_resc(bp, vf); diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index b1627dd5f2fd..328373e0578f 100644
drivers/net/ethernet/broadcom/tg3.c +2 -2
@@ -721,7 +721,7 @@ static int tg3_ape_lock(struct tg3 *tp, int locknum)case TG3_APE_LOCK_GPIO :if (tg3_asic_rev (tp) ==ASIC_REV_5761 )return 0 ; -/* else: fall through */ +/* fall through */ case TG3_APE_LOCK_GRC :case TG3_APE_LOCK_MEM :if (!tp->pci_fn)
@@ -782,7 +782,7 @@ static void tg3_ape_unlock(struct tg3 *tp, int locknum)case TG3_APE_LOCK_GPIO :if (tg3_asic_rev (tp) ==ASIC_REV_5761 )return ; -/* else: fall through */ +/* fall through */ case TG3_APE_LOCK_GRC :case TG3_APE_LOCK_MEM :if (!tp->pci_fn)
--
2.20.1
From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 23 Jan 2019 01:41:19 -0600
Quoted 10 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:6336:6: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:2231:6: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/net/ethernet/broadcom/tg3.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/net/ethernet/broadcom/tg3.c:783:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.