bna: Mark expected switch fall-throughs

PATCH Applied Gustavo A. R. Silva 3 participants 5 messages Jan 23, 2019

Subsystems (3)

Networking Network drivers Brocade bna 10 gigabit Ethernet driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2019-01-23 07:55 UTC #0 lore raw

PATCH 1/1 bna: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

drivers/net/ethernet/brocade/bna/bfa_ioc.c +3 -6

index a36e38676640..cbc9175d74c5 100644
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_INITFAIL:
 		del_timer(&ioc->iocpf_timer);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
+
 	case IOCPF_E_TIMEOUT:
 		bfa_nw_ioc_hw_sem_release(ioc);
 		if (event == IOCPF_E_TIMEOUT)

@@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_FAIL:
 		del_timer(&ioc->iocpf_timer);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through*/
 
 	case IOCPF_E_TIMEOUT:
 		bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);

Signature · 1 line

2.20.1

Sudarsana Reddy Kalluru

maintainer Acked-by Sudarsana Kalluru on v1 1/1

2019-01-23 08:03 UTC #1 lore raw

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: 23 January 2019 13:23
To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] bna: Mark expected switch fall-throughs

External Email

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

drivers/net/ethernet/brocade/bna/bfa_ioc.c +2 -3

index a36e38676640..cbc9175d74c5 100644
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
        case IOCPF_E_INITFAIL:
                del_timer(&ioc->iocpf_timer);
-               /*
-                * !!! fall through !!!
-                */
+               /* fall through */
+
        case IOCPF_E_TIMEOUT:
                bfa_nw_ioc_hw_sem_release(ioc);
                if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)

        case IOCPF_E_FAIL:
                del_timer(&ioc->iocpf_timer);

- /*
- * !!! fall through !!!
- */
+ /* fall through*/

        case IOCPF_E_TIMEOUT:
                bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);

--
2.20.1

Acked-by Sudarsana Kalluru <[email protected]>

Gustavo A. R. Silva

author

2019-01-23 08:06 UTC #2 lore raw

Quoted 54 lines · Sudarsana Reddy Kalluru

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: 23 January 2019 13:23
To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
External Email
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/net/ethernet/brocade/bna/bfa_ioc.c +2 -3
index a36e38676640..cbc9175d74c5 100644
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
        case IOCPF_E_INITFAIL:
                del_timer(&ioc->iocpf_timer);
-               /*
-                * !!! fall through !!!
-                */
+               /* fall through */
+
        case IOCPF_E_TIMEOUT:
                bfa_nw_ioc_hw_sem_release(ioc);
                if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
        case IOCPF_E_FAIL:
                del_timer(&ioc->iocpf_timer);
drivers/net/ethernet/brocade/bna/bfa_ioc.c +1 -4
-               /*
-                * !!! fall through !!!
-                */
+               /* fall through*/
 
        case IOCPF_E_TIMEOUT:
                bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
--
2.20.1

Quoted 2 lines

Acked-by Sudarsana Kalluru <[email protected]>

Thanks, Sudarsana.

--
Gustavo

David Miller

maintainer Applied

2019-01-23 17:07 UTC #4 lore raw

In reply to Gustavo A. R. Silva

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 23 Jan 2019 01:53:28 -0600

Quoted 8 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 6 lines

Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied.

David Miller

maintainer Applied

2019-01-23 17:07 UTC #3 lore raw

In reply to Sudarsana Reddy Kalluru

From: Sudarsana Reddy Kalluru <[email protected]>
Date: Wed, 23 Jan 2019 08:03:12 +0000

Quoted 13 lines

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: 23 January 2019 13:23
To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
External Email
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:

Quoted 8 lines

drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied.