tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC
PATCH 1/1 tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC
--- tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 55 insertions(+), 3 deletions(-)
tools/parser/avdtp.c +55 -3
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 ) +return "aptX Low Latency" ; +else if (vendor ==0x000000d7 && vndcodec ==0x0024 ) +return "aptX HD" ;else if (vendor ==0x0000012d && vndcodec ==0x00aa )return "LDAC" ;return "Unknown" ;
@@ -403,8 +409,10 @@ static void capabilities(int level, struct frame *frm)printf ("%s\n" , tmp &0x80 ?"VBR" :"" );break ;case 255 : -if (vendor ==0x0000004f && - vndcodec ==0x0001 ) { +if ((vendor ==0x0000004f && vndcodec ==0x0001 ) || + (vendor ==0x0000000a && vndcodec ==0x0002 ) || + (vendor ==0x000000d7 && vndcodec ==0x0024 )) { +/* aptX, aptX Low Latency, aptX HD */ tmp =p_get_u8 (frm);p_indent (level +1 , frm);if (tmp &0x80 )
@@ -422,7 +430,51 @@ static void capabilities(int level, struct frame *frm)if (tmp &0x01 )printf ("Mono " );printf ("\n" ); -break ; + }else if (vendor ==0x0000000a && vndcodec ==0x0001 ) { +/* FastStream */ + tmp =p_get_u8 (frm); + freq =p_get_u8 (frm); +if (tmp &0x1 ) { +p_indent (level +1 , frm); +printf ("Sink " ); +if (freq &0x2 ) +printf ("44.1kHz " ); +if (freq &0x1 ) +printf ("48kHz " ); +printf ("\n" ); + } +if (tmp &0x2 ) { +p_indent (level +1 , frm); +printf ("Source " ); +if (freq &0x20 ) +printf ("16kHz " ); +printf ("\n" ); + } + }else if (vendor ==0x0000012d && vndcodec ==0x00aa ) { +/* LDAC */ + tmp =p_get_u8 (frm); +p_indent (level +1 , frm); +if (tmp &0x20 ) +printf ("44.1kHz " ); +if (tmp &0x10 ) +printf ("48kHz " ); +if (tmp &0x08 ) +printf ("88.2kHz " ); +if (tmp &0x04 ) +printf ("96kHz " ); +if (tmp &0x02 ) +printf ("176.4kHz " ); +if (tmp &0x01 ) +printf ("192kHz " ); +printf ("\n" ); +p_indent (level +1 , frm); +if (tmp &0x01 ) +printf ("Stereo " ); +if (tmp &0x02 ) +printf ("Dual " ); +if (tmp &0x04 ) +printf ("Mono " ); +printf ("\n" ); }else {hex_dump (level +1 , frm, len -8 ); frm->ptr += (len -8 );
Signature · 1 line
2.11.0
Marcel Holtmann
maintainerHi Pali,
Quoted 11 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +0
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 10 lines
tools/parser/avdtp.c +6
-0return "aptX" ; + else if (vendor == 0x0000000a && vndcodec == 0x0001) +return "FastStream" ; + else if (vendor == 0x0000000a && vndcodec == 0x0002) +return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown”;
lets keep the focus on btmon support since nobody should be using hcidump anymore.
Regards
Marcel
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )
Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown”;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Regards
Marcel
Signature · 2 lines
Pali Rohár [email protected]
Quoted 27 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
Quoted 5 lines
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Quoted 8 lines
Quoted 4 lines
Regards
Marcel
Signature · 2 lines
Pali Rohár [email protected]
-- Pasi
Quoted 28 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 27 lines · Pali Rohár
Quoted 25 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 11 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +0
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 10 lines
tools/parser/avdtp.c +6
-0return "aptX" ; + else if (vendor == 0x0000000a && vndcodec == 0x0001) +return "FastStream" ; + else if (vendor == 0x0000000a && vndcodec == 0x0002) +return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
Quoted 8 lines
Quoted 5 lines
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Quoted 13 lines
Quoted 9 lines
Quoted 5 lines
Regards
Marcel
Signature · 2 lines
Pali Rohár [email protected]-- Pasi
Signature · 2 lines
Pali Rohár [email protected]
Luiz Augusto von Dentz
maintainerHi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated tools/etc.
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Regards
Marcel
Quoted 7 lines
Quoted 3 lines
--
Pali Rohár
[email protected]-- Pasi
--
Pali Rohár
[email protected]
Signature · 1 line
Luiz Augusto von Dentz
Hi,
Quoted 43 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Quoted 8 lines
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.
+1 for doing one last 5.x release before deprecating and removing tools etc!
-- Pasi
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
Signature · 2 lines
Pali Rohár [email protected]
Quoted 52 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Any news about next bluez release?
Quoted 3 lines
Signature · 2 lines
Pali Rohár [email protected]
Thanks,
-- Pasi
Quoted 57 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 56 lines · Pali Rohár
Quoted 55 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 51 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
So... what are plans for next release?
Quoted 13 lines
Any news about next bluez release?
Quoted 3 lines
Signature · 2 lines
Pali Rohár [email protected]Thanks,
-- Pasi
Signature · 2 lines
Pali Rohár [email protected]
Quoted 60 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 59 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 58 lines · Pali Rohár
Quoted 56 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 43 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Quoted 8 lines
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
Quoted 14 lines
Quoted 13 lines
Any news about next bluez release?
Quoted 3 lines
Signature · 2 lines
Pali Rohár [email protected]Thanks,
-- Pasi
Signature · 2 lines
Pali Rohár [email protected]
Quoted 65 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 64 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 63 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 61 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Signature · 2 lines
Pali Rohár [email protected]
Quoted 69 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 68 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 67 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 65 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 52 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c| 58 +++++++++++++++++++++++++++++++++++++++++++++++++---1 file changed, 55 insertions(+), 3 deletions(-)tools/parser/avdtp.c +3
-0@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) {if (vendor ==0x0000004f && vndcodec ==0x0001 )return "aptX" ; +else if (vendor ==0x0000000a && vndcodec ==0x0001 ) +return "FastStream" ; +else if (vendor ==0x0000000a && vndcodec ==0x0002 )Quoted 8 lines
tools/parser/avdtp.c static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) · line 166
Quoted 6 lines
tools/parser/avdtp.c +3
-0+return "aptX Low Latency" ; + else if (vendor == 0x000000d7 && vndcodec == 0x0024) +return "aptX HD" ; else if (vendor == 0x0000012d && vndcodec == 0x00aa)return "LDAC" ; return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Just a gentle reminder for this thread and patch.
Signature · 2 lines
Pali Rohár [email protected]
Quoted 70 lines · On Monday 14 October 2019 13:07:46 Pali Rohár wrote:
Quoted 69 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 68 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 67 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 65 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 52 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 17 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
Quoted 15 lines
---
tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
index 18569c895..a21410f5a 100644
--- a/tools/parser/avdtp.c
+++ b/tools/parser/avdtp.c
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
{
if (vendor == 0x0000004f && vndcodec == 0x0001)
return "aptX";
+ else if (vendor == 0x0000000a && vndcodec == 0x0001)
+ return "FastStream";
+ else if (vendor == 0x0000000a && vndcodec == 0x0002)Quoted 8 lines
Quoted 6 lines
+ return "aptX Low Latency";
+ else if (vendor == 0x000000d7 && vndcodec == 0x0024)
+ return "aptX HD";
else if (vendor == 0x0000012d && vndcodec == 0x00aa)
return "LDAC";
return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Just a gentle reminder for this thread and patch.
Ping, another reminder.
Signature · 2 lines
Pali Rohár [email protected]
Quoted 76 lines · On Sunday 09 February 2020 14:05:32 Pali Rohár wrote:
Quoted 75 lines · On Monday 14 October 2019 13:07:46 Pali Rohár wrote:
Quoted 74 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 72 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 60 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 59 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 58 lines · Pali Rohár
Quoted 56 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 43 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
Quoted 25 lines · On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,
---
tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
index 18569c895..a21410f5a 100644
--- a/tools/parser/avdtp.c
+++ b/tools/parser/avdtp.c
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
{
if (vendor == 0x0000004f && vndcodec == 0x0001)
return "aptX";
+ else if (vendor == 0x0000000a && vndcodec == 0x0001)
+ return "FastStream";
+ else if (vendor == 0x0000000a && vndcodec == 0x0002)
+ return "aptX Low Latency";
+ else if (vendor == 0x000000d7 && vndcodec == 0x0024)
+ return "aptX HD";
else if (vendor == 0x0000012d && vndcodec == 0x00aa)
return "LDAC";
return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just found another place where this capability parsing is implemented and based on fact that users still use hcidump I quickly looked at it and implemented this parsing.
Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Quoted 8 lines
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
PING!
Just a gentle reminder for this thread and patch.
Ping, another reminder.
Ping, could you please give us information what is the state of this tool and a linked patch?
Quoted 79 lines · On Wednesday 15 April 2020 01:00:15 Pali Rohár wrote:
Quoted 78 lines · On Sunday 09 February 2020 14:05:32 Pali Rohár wrote:
Quoted 77 lines · On Monday 14 October 2019 13:07:46 Pali Rohár wrote:
Quoted 75 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 65 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 64 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 63 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 61 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
Quoted 32 lines · Pali Rohár
On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,---
tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
index 18569c895..a21410f5a 100644
--- a/tools/parser/avdtp.c
+++ b/tools/parser/avdtp.c
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
{
if (vendor == 0x0000004f && vndcodec == 0x0001)
return "aptX";
+ else if (vendor == 0x0000000a && vndcodec == 0x0001)
+ return "FastStream";
+ else if (vendor == 0x0000000a && vndcodec == 0x0002)
+ return "aptX Low Latency";
+ else if (vendor == 0x000000d7 && vndcodec == 0x0024)
+ return "aptX HD";
else if (vendor == 0x0000012d && vndcodec == 0x00aa)
return "LDAC";
return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just
found another place where this capability parsing is implemented and
based on fact that users still use hcidump I quickly looked at it and
implemented this parsing.Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Just a gentle reminder for this thread and patch.
Ping, another reminder.
Ping, could you please give us information what is the state of this tool and a linked patch?
Ping again, I have not got any reply for this patch for more then year. Patch can be still cleanly applied on top of git master branch.
Quoted 83 lines · On Sunday 03 May 2020 13:14:49 Pali Rohár wrote:
Quoted 82 lines · On Wednesday 15 April 2020 01:00:15 Pali Rohár wrote:
Quoted 81 lines · On Sunday 09 February 2020 14:05:32 Pali Rohár wrote:
Quoted 79 lines · On Monday 14 October 2019 13:07:46 Pali Rohár wrote:
Quoted 69 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 68 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 67 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 65 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 52 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 36 lines · Pali Rohár
Quoted 34 lines · On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,---
tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
index 18569c895..a21410f5a 100644
--- a/tools/parser/avdtp.c
+++ b/tools/parser/avdtp.c
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
{
if (vendor == 0x0000004f && vndcodec == 0x0001)
return "aptX";
+ else if (vendor == 0x0000000a && vndcodec == 0x0001)
+ return "FastStream";
+ else if (vendor == 0x0000000a && vndcodec == 0x0002)
+ return "aptX Low Latency";
+ else if (vendor == 0x000000d7 && vndcodec == 0x0024)
+ return "aptX HD";
else if (vendor == 0x0000012d && vndcodec == 0x00aa)
return "LDAC";
return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just
found another place where this capability parsing is implemented and
based on fact that users still use hcidump I quickly looked at it and
implemented this parsing.Quoted 4 lines
Quoted 2 lines
I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Just a gentle reminder for this thread and patch.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Ping, another reminder.
Ping, could you please give us information what is the state of this tool and a linked patch?
Ping again, I have not got any reply for this patch for more then year. Patch can be still cleanly applied on top of git master branch.
Hello! Have you had a time to look at this patch?
Quoted 86 lines · On Saturday 08 August 2020 15:24:58 Pali Rohár wrote:
Quoted 85 lines · On Sunday 03 May 2020 13:14:49 Pali Rohár wrote:
Quoted 84 lines · On Wednesday 15 April 2020 01:00:15 Pali Rohár wrote:
Quoted 82 lines · On Sunday 09 February 2020 14:05:32 Pali Rohár wrote:
Quoted 70 lines · On Monday 14 October 2019 13:07:46 Pali Rohár wrote:
Quoted 69 lines · On Friday 07 June 2019 15:07:39 Pali Rohár wrote:
Quoted 68 lines · On Wednesday 10 April 2019 10:29:24 Pali Rohár wrote:
Quoted 67 lines · On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
Quoted 65 lines · On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
Quoted 52 lines · Pali Rohár
Quoted 51 lines · On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
Hi,
Quoted 48 lines · Luiz Augusto von Dentz
Hi Pali, Pasi,
Quoted 40 lines · Pali Rohár
On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
Hi Pali,---
tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
index 18569c895..a21410f5a 100644
--- a/tools/parser/avdtp.c
+++ b/tools/parser/avdtp.c
@@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
{
if (vendor == 0x0000004f && vndcodec == 0x0001)
return "aptX";
+ else if (vendor == 0x0000000a && vndcodec == 0x0001)
+ return "FastStream";
+ else if (vendor == 0x0000000a && vndcodec == 0x0002)
+ return "aptX Low Latency";
+ else if (vendor == 0x000000d7 && vndcodec == 0x0024)
+ return "aptX HD";
else if (vendor == 0x0000012d && vndcodec == 0x00aa)
return "LDAC";
return "Unknown???;lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just
found another place where this capability parsing is implemented and
based on fact that users still use hcidump I quickly looked at it and
implemented this parsing.I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.Exactly, people still use hcidump...
Well it is a deprecated tool which we might remove starting on BlueZ 6.x which we would like to do in the very next release, if that doesn't happen than perhaps Id take these patches in for a very last BlueZ 5.x release.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
@Marcel: Or you have a better plan? We could do one last 5.x and then start working on removing the deprecated
tools/etc.+1 for doing one last 5.x release before deprecating and removing tools etc!
Ok, what is the plan? If hcidump is not going to be deleted in upcoming release, can you take this patch?
How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your info here for more than 2 months.
PING!
Just a gentle reminder for this thread and patch.
Ping, another reminder.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Ping, could you please give us information what is the state of this tool and a linked patch?
Ping again, I have not got any reply for this patch for more then year. Patch can be still cleanly applied on top of git master branch.
Hello! Have you had a time to look at this patch?
BUMP