regmap: Remove attribute packed from struct 'regcache_rbtree_node'
Subsystems (2)
PATCH 1/1 regmap: Remove attribute packed from struct 'regcache_rbtree_node'
On one hand commit 28644c809f44 ("regmap: Add the rbtree cache support") added 'regcache_rbtree_node' as packed structure, while on the other hand commit e977145aeaad ("[RBTREE] Add explicit alignment to sizeof(long) for struct rb_node.") declared struct 'rb_node' as aligned.
Solve the ambiguity of placing aligned structure in a packed one by removing the packed attribute from struct. This seems to be the behavior of gcc anyway.
This removes the following warning (W=1):
drivers/base/regmap/regcache-rbtree.c:36:1: warning: alignment 1 of 'struct regcache_rbtree_node' is less than 4 [-Wpacked-not-aligned]
Cc Dimitris Papastamos <[email protected]>
Cc David Woodhouse <[email protected]>
Signed-off-by Mathieu Malaterre <[email protected]>
--- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/regmap/regcache-rbtree.c +1 -1
@@ -33,7 +33,7 @@ struct regcache_rbtree_node {unsigned int blklen;/* the actual rbtree node holding this block */ struct rb_node node; -} __attribute__ ((packed)); +};struct regcache_rbtree_ctx {struct rb_root root;
Signature · 1 line
2.19.2