security: mark expected switch fall-throughs
Subsystems (6)
PATCH 1/1 security: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=] security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=] security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=] security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=] security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=] security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=] security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=] security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)
security/apparmor/domain.c +1 -1
@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */
security/integrity/ima/ima_appraise.c +1 -0
@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */ case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;
security/integrity/ima/ima_policy.c +4 -0
@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||
@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);
security/integrity/ima/ima_template_lib.c +1 -0
@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)
security/smack/smack_lsm.c +1 -2
@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Signature · 1 line
2.20.1
Quoted 14 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=]security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 5 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Ug. It can't be part of a greater comment? Grumble.
Quoted 93 lines
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)security/apparmor/domain.c +1
-1@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */ security/integrity/ima/ima_appraise.c +1
-0@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */ case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;security/integrity/ima/ima_policy.c +4
-0@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);security/integrity/ima/ima_template_lib.c +1
-0@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)security/smack/smack_lsm.c +1
-2@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Quoted 17 lines · Casey Schaufler
Quoted 16 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=]security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]Warning level 3 was used: -Wimplicit-fallthrough=3
Quoted 8 lines
Quoted 3 lines
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Acked-by Casey Schaufler <[email protected]>Ug. It can't be part of a greater comment? Grumble.
Not like the one in this case.
It can be part of a one line comment like this:
/* fall through - ... */
and it has to be placed at the bottom of the case.
I know... I'd be great if this can be improved.
Quoted 93 lines
Quoted 93 lines
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)security/apparmor/domain.c +1
-1@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */ security/integrity/ima/ima_appraise.c +1
-0@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */ case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;security/integrity/ima/ima_policy.c +4
-0@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);security/integrity/ima/ima_template_lib.c +1
-0@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)security/smack/smack_lsm.c +1
-2@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Quoted 18 lines · Gustavo A. R. Silva
Quoted 15 lines · Casey Schaufler
Quoted 14 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=]security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Acked-by Casey Schaufler <[email protected]>
BTW, thanks, Casey. I'll take this in my tree.
--
Gustavo
Quoted 106 lines
Quoted 2 lines
Ug. It can't be part of a greater comment? Grumble.
Not like the one in this case.
It can be part of a one line comment like this:
/* fall through - ... */
and it has to be placed at the bottom of the case.
I know... I'd be great if this can be improved.
Quoted 93 lines
Quoted 93 lines
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)security/apparmor/domain.c +1
-1@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */ security/integrity/ima/ima_appraise.c +1
-0@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */ case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;security/integrity/ima/ima_policy.c +4
-0@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);security/integrity/ima/ima_template_lib.c +1
-0@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)security/smack/smack_lsm.c +1
-2@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Quoted 14 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=]security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 5 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
looks good to me
Quoted 94 lines
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)security/apparmor/domain.c +1
-1@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */ security/integrity/ima/ima_appraise.c +1
-0@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */ case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;security/integrity/ima/ima_policy.c +4
-0@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);security/integrity/ima/ima_template_lib.c +1
-0@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)security/smack/smack_lsm.c +1
-2@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Mimi Zohar
maintainerQuoted 14 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=]security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=]security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=]security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 5 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Other than the one question in ima_appraise.c, the rest of the IMA changes are fine.
Mimi
Quoted 26 lines
--- security/apparmor/domain.c | 2 +- security/integrity/ima/ima_appraise.c | 1 + security/integrity/ima/ima_policy.c | 4 ++++ security/integrity/ima/ima_template_lib.c | 1 + security/smack/smack_lsm.c | 3 +-- 5 files changed, 8 insertions(+), 3 deletions(-)security/apparmor/domain.c +1
-1@@ -572,7 +572,7 @@ static struct aa_label *x_to_label(struct aa_profile *profile, stack =NULL ;break ; } -/* fall through to X_NAME */ +/* fall through - to X_NAME */ case AA_X_NAME :if (xindex &AA_X_CHILD )/* released by caller */ security/integrity/ima/ima_appraise.c +0
-0
security/integrity/ima/ima_appraise.c static void ima_set_cache_status(struct integrity_iint_cache *iint, · line 117
Quoted 4 lines
security/integrity/ima/ima_appraise.c +1
-0@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,break ;case CREDS_CHECK : iint->ima_creds_status = status; +/* fall through */
Matthew, is this right?
Quoted 63 lines
security/integrity/ima/ima_appraise.c +0
-0case FILE_CHECK :case POST_SETATTR : iint->ima_file_status = status;security/integrity/ima/ima_policy.c +4
-0@@ -938,10 +938,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)case Opt_uid_gt:case Opt_euid_gt: entry->uid_op = &uid_gt; +/* fall through */ case Opt_uid_lt:case Opt_euid_lt:if ((token == Opt_uid_lt) || (token == Opt_euid_lt)) entry->uid_op = &uid_lt; +/* fall through */ case Opt_uid_eq:case Opt_euid_eq: uid_token = (token == Opt_uid_eq) ||@@ -970,9 +972,11 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)break ;case Opt_fowner_gt: entry->fowner_op = &uid_gt; +/* fall through */ case Opt_fowner_lt:if (token == Opt_fowner_lt) entry->fowner_op = &uid_lt; +/* fall through */ case Opt_fowner_eq:ima_log_string_op (ab,"fowner" , args[0 ].from, entry->fowner_op);security/integrity/ima/ima_template_lib.c +1
-0@@ -83,6 +83,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,/* skip ':' and '\0' */ buf_ptr +=2 ; buflen -= buf_ptr - field_data->data; +/* fall through */ case DATA_FMT_DIGEST :case DATA_FMT_HEX :if (!buflen)security/smack/smack_lsm.c +1
-2@@ -3391,13 +3391,12 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)*/ final = &smack_known_star;/* -* Fall through. -* * If a smack value has been set we want to use it, * but since tmpfs isn't giving us the opportunity * to set mount options simulate setting the * superblock default. */ +/* Fall through */ default :/* * This isn't an understood special case.
Mimi Zohar
maintainer[Cc'ing James Morris]
Quoted 6 lines · Gustavo A. R. Silva
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>Acked-by Casey Schaufler <[email protected]>BTW, thanks, Casey. I'll take this in my tree.
This patch touches multiple LSMs and IMA. As James has already picked up similar patches, which are in his next-general branch, perhaps he could also pick up an updated version of this one.
Mimi
Mimi,
Quoted 6 lines · Mimi Zohar
[Cc'ing James Morris]
Quoted 2 lines · Gustavo A. R. Silva
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Acked-by Casey Schaufler <[email protected]>BTW, thanks, Casey. I'll take this in my tree.
This patch touches multiple LSMs and IMA. As James has already picked up similar patches, which are in his next-general branch, perhaps he could also pick up an updated version of this one.
Yeah. I can either integrate your recent fix and respin if you don't mind, or remove the fall-through comment and wait for James to take both patches, yours and mine.
What do you prefer?
Thanks
--
Gustavo
Mimi Zohar
maintainerQuoted 19 lines · Gustavo A. R. Silva
Mimi,
Quoted 6 lines · Mimi Zohar
[Cc'ing James Morris]
Quoted 2 lines · Gustavo A. R. Silva
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Acked-by Casey Schaufler <[email protected]>BTW, thanks, Casey. I'll take this in my tree.
This patch touches multiple LSMs and IMA. As James has already picked up similar patches, which are in his next-general branch, perhaps he could also pick up an updated version of this one.
Quoted 5 lines
Yeah. I can either integrate your recent fix and respin if you don't mind, or remove the fall-through comment and wait for James to take both patches, yours and mine.
What do you prefer?
Either way is fine.
Mimi
Quoted 6 lines · Mimi Zohar
Quoted 6 lines
Quoted 5 lines
This patch touches multiple LSMs and IMA. As James has already picked up similar patches, which are in his next-general branch, perhaps he could also pick up an updated version of this one.
Quoted 8 lines
Quoted 5 lines
Yeah. I can either integrate your recent fix and respin if you don't mind, or remove the fall-through comment and wait for James to take both patches, yours and mine.
What do you prefer?
Either way is fine.
OK. Well, I think in this case less is more, so I will integrate our changes into a single patch.
Thanks for your feedback.
--
Gustavo
James Morris
maintainerQuoted 14 lines · Gustavo A. R. Silva
Quoted 10 lines · Mimi Zohar
Quoted 10 lines
Quoted 5 lines
This patch touches multiple LSMs and IMA. As James has already picked up similar patches, which are in his next-general branch, perhaps he could also pick up an updated version of this one.
Yeah. I can either integrate your recent fix and respin if you don't mind, or remove the fall-through comment and wait for James to take both patches, yours and mine.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
What do you prefer?
Either way is fine.
OK. Well, I think in this case less is more, so I will integrate our changes into a single patch.
WFM
Signature · 2 lines
James Morris <[email protected]>