Skip to contentSkip to conversation

lib/cmdline.c: mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Jan 25, 2019 – Jan 26, 2019 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/cmdline.c: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.

---
 lib/cmdline.c | 5 +++++
 1 file changed, 5 insertions(+)
lib/cmdline.c +5 -0
index 171c19b6888e..dc59d6216318 100644
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
 	case 'E':
 	case 'e':
 		ret <<= 10;
+		/* fall through */
 	case 'P':
 	case 'p':
 		ret <<= 10;
+		/* fall through */
 	case 'T':
 	case 't':
 		ret <<= 10;
+		/* fall through */
 	case 'G':
 	case 'g':
 		ret <<= 10;
+		/* fall through */
 	case 'M':
 	case 'm':
 		ret <<= 10;
+		/* fall through */
 	case 'K':
 	case 'k':
 		ret <<= 10;
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 5 lines

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.

-Kees

Quoted 35 lines
---
 lib/cmdline.c | 5 +++++
 1 file changed, 5 insertions(+)
lib/cmdline.c +5 -1
index 171c19b6888e..dc59d6216318 100644
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
        case 'E':
        case 'e':
                ret <<= 10;
+               /* fall through */
        case 'P':
        case 'p':
                ret <<= 10;
+               /* fall through */
        case 'T':
        case 't':
                ret <<= 10;
+               /* fall through */
        case 'G':
        case 'g':
                ret <<= 10;
+               /* fall through */
        case 'M':
        case 'm':
                ret <<= 10;
+               /* fall through */
        case 'K':
        case 'k':
                ret <<= 10;
--

2.20.1

Signature · 1 line
Kees Cook
#2 lore raw
Quoted 14 lines · Kees Cook
Quoted 12 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 8 lines
Quoted 5 lines

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.

Now applied to for-next/kspp, thanks.

https://git.kernel.org/gustavoars/c/5dd481673c3ddd27d36851754bafbaa82bdff34f

Cheers!
--
Gustavo