Skip to contentSkip to conversation

fpga: stratix10-soc: fix wrong of_node_put() in init function

PATCH New Alan Tull 1 participant 1 message Jan 26, 2019 FPGA manager framework

lore
Share & tools
lore

Alan Tull

author
#0 lore raw

PATCH 1/1 fpga: stratix10-soc: fix wrong of_node_put() in init function

From: Nicolas Saenz Julienne <[email protected]>

After finding a "firmware" dt node stratix10 tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again.

This patch removes the unwarranted call to of_node_put().

Fixes e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
[atull: remove unnecessary braces]
---
 drivers/fpga/stratix10-soc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/fpga/stratix10-soc.c +1 -4
index a1a09e04fab8..13851b3d1c56 100644
@@ -508,14 +508,11 @@ static int __init s10_init(void)
 		return -ENODEV;
 
 	np = of_find_matching_node(fw_np, s10_of_match);
-	if (!np) {
-		of_node_put(fw_np);
+	if (!np)
 		return -ENODEV;
-	}
 
 	of_node_put(np);
 	ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL);
-	of_node_put(fw_np);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.20.1