Skip to contentSkip to conversation

MIPS: Select PINCTRL_RT2880 when RALINK is enabled

PATCH In review Nishad Kamdar 2 participants 3 messages Jan 29, 2019 – Jan 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: Select PINCTRL_RT2880 when RALINK is enabled

This patch selects config PINCTRL_RT2880 when config RALINK is enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL is also selected when RALINK is enabled to avoid config dependency warnings.

---
 arch/mips/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/Kconfig +2 -0
index e2fc88da0223..cea529cf6284 100644
@@ -623,6 +623,8 @@ config RALINK
 	select CLKDEV_LOOKUP
 	select ARCH_HAS_RESET_CONTROLLER
 	select RESET_CONTROLLER
+	select PINCTRL
+	select PINCTRL_RT2880
 
 config SGI_IP22
 	bool "SGI IP22 (Indy/Indigo2)"
Signature · 1 line
2.17.1
#1 lore raw

Hi Nishad,

Quoted 15 lines · Nishad Kamdar

This patch selects config PINCTRL_RT2880 when config RALINK is enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL is also selected when RALINK is enabled to avoid config dependency warnings.

---
 arch/mips/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/Kconfig +0 -0
index e2fc88da0223..cea529cf6284 100644

arch/mips/Kconfig config RALINK · line 630

Quoted 8 lines
arch/mips/Kconfig +2 -0
@@ -623,6 +623,8 @@ config RALINK
 	select CLKDEV_LOOKUP
 	select ARCH_HAS_RESET_CONTROLLER
 	select RESET_CONTROLLER
+	select PINCTRL
+	select PINCTRL_RT2880
 
 config SGI_IP22
 	bool "SGI IP22 (Indy/Indigo2)"

Wouldn't this also require selecting STAGING? Perhaps that's why it wasn't done in the first place?

Thanks,
Paul

#2 lore raw
Quoted 24 lines · Paul Burton

Hi Nishad,

Quoted 21 lines · Nishad Kamdar

This patch selects config PINCTRL_RT2880 when config RALINK is enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL is also selected when RALINK is enabled to avoid config dependency warnings.

---
 arch/mips/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/Kconfig +2 -0
index e2fc88da0223..cea529cf6284 100644
@@ -623,6 +623,8 @@ config RALINK
 	select CLKDEV_LOOKUP
 	select ARCH_HAS_RESET_CONTROLLER
 	select RESET_CONTROLLER
+	select PINCTRL
+	select PINCTRL_RT2880
 
Quoted 8 lines

arch/mips/Kconfig config RALINK · line 630

Quoted 2 lines
arch/mips/Kconfig +0 -0
 config SGI_IP22
 	bool "SGI IP22 (Indy/Indigo2)"

Wouldn't this also require selecting STAGING? Perhaps that's why it wasn't done in the first place?

Thanks,
Paul

Ok, got it.

Thanks for the review.

Regards,
Nishad