Skip to contentSkip to conversation

usb: typec: ucsi: add firmware flashing support

PATCH New Greg Kroah-Hartman 1 participant 1 message Jan 30, 2019 USB

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH v2 6/6 usb: typec: ucsi: add firmware flashing support

Quoted 5 lines · Ajay Gupta
(quoted diff) +5 -0
+	/*****************************************************************
+	 * CCG firmware image (.cyacd) file line format
+	 *
+	 * :00rrrrllll[dd....]cc/r/n
+	 *

Review

Quoted 10 lines
(quoted diff) +10 -0
+	 * :00   header
+	 * rrrr is row number to flash				(4 char)
+	 * llll is data len to flash				(4 char)
+	 * dd   is a data field represents one byte of data	(512 char)
+	 * cc   is checksum					(2 char)
+	 * \r\n newline
+	 *
+	 * Total length: 3 + 4 + 4 + 512 + 2 + 2 = 527
+	 *
+	 *****************************************************************/

Any reason you can't just use ihex for this so that you don't have to parse it all and you can just use the in-kernel functions for it? Why make a custom firmware image type?

thanks,

greg k-h