Skip to contentSkip to conversation

serdev: ttyport: call tiocmget and tiocmset ops directly

PATCH New Johan Hovold 1 participant 1 message Jan 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serdev: ttyport: call tiocmget and tiocmset ops directly

The tty struct holds a pointer to the driver's tty operations so drop the unnecessary driver dereference when calling tiocmget and tiocmset.

Note that this also makes the calls match the preceding sanity checks as expected.

---
 drivers/tty/serdev/serdev-ttyport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serdev/serdev-ttyport.c +2 -2
index fa1672993b4c..d1cdd2ab8b4c 100644
@@ -233,7 +233,7 @@ static int ttyport_get_tiocm(struct serdev_controller *ctrl)
 	if (!tty->ops->tiocmget)
 		return -ENOTSUPP;
 
-	return tty->driver->ops->tiocmget(tty);
+	return tty->ops->tiocmget(tty);
 }
 
 static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, unsigned int clear)
@@ -244,7 +244,7 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	if (!tty->ops->tiocmset)
 		return -ENOTSUPP;
 
-	return tty->driver->ops->tiocmset(tty, set, clear);
+	return tty->ops->tiocmset(tty, set, clear);
 }
 
 static const struct serdev_controller_ops ctrl_ops = {
Signature · 1 line
2.20.1