Skip to contentSkip to conversation

x86/pvh-boot: don't mandate validity of RSDP pointer

PATCH In review Wei Liu 3 participants 3 messages Jan 30, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH v2 1/1 x86/pvh-boot: don't mandate validity of RSDP pointer

RSDP is not mandatory according to PVH spec. Remove the BUG_ON. The guest (xen) will fall back to scanning if necessary.

---
 xen/arch/x86/guest/pvh-boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/arch/x86/guest/pvh-boot.c +0 -1
index 544775eeb4..ca8e156f7d 100644
@@ -79,7 +79,6 @@ static void __init convert_pvh_info(multiboot_info_t **mbi,
         pvh_mbi_mods[i].string    = entry[i].cmdline_paddr;
     }
 
-    BUG_ON(!pvh_info->rsdp_paddr);
     rsdp_hint = pvh_info->rsdp_paddr;
 
     *mbi = &pvh_mbi;
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw
In reply to Wei Liu
Quoted 5 lines · Wei Liu

RSDP is not mandatory according to PVH spec. Remove the BUG_ON. The guest (xen) will fall back to scanning if necessary.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel