drm/amd/display: Use memset to initialize variable in wait_for_training_aux_rd_interval
Subsystems (3)
PATCH 1/1 drm/amd/display: Use memset to initialize variable in wait_for_training_aux_rd_interval
Clang warns:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:50:57:
warning: suggest braces around initialization of subobject [-Wmissing-braces]
union training_aux_rd_interval training_rd_interval = {0};
^
{}1 warning generated.
Previous efforts to fix this type of warning by adding or removing braces have been met with some pushback in favor of using memset [1][2]. Do that here, mirroring commit 05794eff1aa6 ("drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces] (V2)") in this tree.
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/lkml/[email protected]/
Fixes 3cec41769d21 ("drm/amd/display: Fix use of uninitialized union")
Signed-off-by Nathan Chancellor <[email protected]>
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +3 -1
@@ -47,7 +47,9 @@ static void wait_for_training_aux_rd_interval( struct dc_link *link, uint32_t default_wait_in_micro_secs) { -union training_aux_rd_interval training_rd_interval = {0 }; +union training_aux_rd_interval training_rd_interval; + +memset (&training_rd_interval,0 ,sizeof (training_rd_interval));/* overwrite the delay if rev > 1.1*/ if (link->dpcd_caps.dpcd_rev.raw >=DPCD_REV_12 ) {
Signature · 1 line
2.20.1