virtio: drop internal struct from UAPI
Michael S. Tsirkin
maintainerPATCH 1/1 virtio: drop internal struct from UAPI
There's no reason to expose struct vring_packed in UAPI - if we do we won't be able to change or drop it, and it's not part of any interface.
Let's move it to virtio_ring.c
--- drivers/virtio/virtio_ring.c | 7 ++++++- include/uapi/linux/virtio_ring.h | 10 ---------- 2 files changed, 6 insertions(+), 11 deletions(-)
drivers/virtio/virtio_ring.c +6 -1
@@ -152,7 +152,12 @@ struct vring_virtqueue {/* Available for packed ring */ struct {/* Actual memory layout for this queue. */ -struct vring_packed vring; +struct { +unsigned int num; +struct vring_packed_desc *desc; +struct vring_packed_desc_event *driver; +struct vring_packed_desc_event *device; + } vring;/* Driver ring wrap counter. */ bool avail_wrap_counter;
include/uapi/linux/virtio_ring.h +0 -10
@@ -213,14 +213,4 @@ struct vring_packed_desc { __le16 flags; }; -struct vring_packed { -unsigned int num; - -struct vring_packed_desc *desc; - -struct vring_packed_desc_event *driver; - -struct vring_packed_desc_event *device; -}; -#endif /* _UAPI_LINUX_VIRTIO_RING_H */
Signature · 1 line
MST
Quoted 39 lines · Michael S. Tsirkin
There's no reason to expose struct
vring_packedin UAPI - if we do we won't be able to change or drop it, and it's not part of any interface.Let's move it to
virtio_ring.cCc Tiwei Bie <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_ring.c | 7 ++++++- include/uapi/linux/virtio_ring.h | 10 ---------- 2 files changed, 6 insertions(+), 11 deletions(-)drivers/virtio/virtio_ring.c +6
-1@@ -152,7 +152,12 @@ struct vring_virtqueue {/* Available for packed ring */ struct {/* Actual memory layout for this queue. */ -struct vring_packed vring; +struct { +unsigned int num; +struct vring_packed_desc *desc; +struct vring_packed_desc_event *driver; +struct vring_packed_desc_event *device; + } vring;/* Driver ring wrap counter. */ bool avail_wrap_counter;include/uapi/linux/virtio_ring.h +0
-1@@ -213,14 +213,4 @@ struct vring_packed_desc {__le16 flags; }; -struct vring_packed {
include/uapi/linux/virtio_ring.h struct vring_packed_desc { · line 216
Quoted 10 lines
include/uapi/linux/virtio_ring.h +0
-9-unsigned int num; - -struct vring_packed_desc *desc; - -struct vring_packed_desc_event *driver; - - struct vring_packed_desc_event *device; -}; -#endif /* _UAPI_LINUX_VIRTIO_RING_H */
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 39 lines · Michael S. Tsirkin
There's no reason to expose struct
vring_packedin UAPI - if we do we won't be able to change or drop it, and it's not part of any interface.Let's move it to
virtio_ring.cCc Tiwei Bie <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_ring.c | 7 ++++++- include/uapi/linux/virtio_ring.h | 10 ---------- 2 files changed, 6 insertions(+), 11 deletions(-)drivers/virtio/virtio_ring.c +6
-1@@ -152,7 +152,12 @@ struct vring_virtqueue {/* Available for packed ring */ struct {/* Actual memory layout for this queue. */ -struct vring_packed vring; +struct { +unsigned int num; +struct vring_packed_desc *desc; +struct vring_packed_desc_event *driver; +struct vring_packed_desc_event *device; + } vring;/* Driver ring wrap counter. */ bool avail_wrap_counter;include/uapi/linux/virtio_ring.h +0
-1@@ -213,14 +213,4 @@ struct vring_packed_desc {__le16 flags; }; -struct vring_packed {
include/uapi/linux/virtio_ring.h struct vring_packed_desc { · line 216
Quoted 10 lines
include/uapi/linux/virtio_ring.h +0
-9-unsigned int num; - -struct vring_packed_desc *desc; - -struct vring_packed_desc_event *driver; - - struct vring_packed_desc_event *device; -}; -#endif /* _UAPI_LINUX_VIRTIO_RING_H */
Quoted 51 lines · Michael S. Tsirkin
There's no reason to expose struct
vring_packedin UAPI - if we do we won't be able to change or drop it, and it's not part of any interface.Let's move it to
virtio_ring.cCc Tiwei Bie <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_ring.c | 7 ++++++- include/uapi/linux/virtio_ring.h | 10 ---------- 2 files changed, 6 insertions(+), 11 deletions(-)drivers/virtio/virtio_ring.c +6
-1@@ -152,7 +152,12 @@ struct vring_virtqueue {/* Available for packed ring */ struct {/* Actual memory layout for this queue. */ -struct vring_packed vring; +struct { +unsigned int num; +struct vring_packed_desc *desc; +struct vring_packed_desc_event *driver; +struct vring_packed_desc_event *device; + } vring;/* Driver ring wrap counter. */ bool avail_wrap_counter;include/uapi/linux/virtio_ring.h +0
-10@@ -213,14 +213,4 @@ struct vring_packed_desc { __le16 flags; }; -struct vring_packed { -unsigned int num; - -struct vring_packed_desc *desc; - -struct vring_packed_desc_event *driver; - -struct vring_packed_desc_event *device; -}; -#endif /* _UAPI_LINUX_VIRTIO_RING_H */ Signature · 1 line
MST
Quoted 51 lines · Michael S. Tsirkin
There's no reason to expose struct
vring_packedin UAPI - if we do we won't be able to change or drop it, and it's not part of any interface.Let's move it to
virtio_ring.cCc Tiwei Bie <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_ring.c | 7 ++++++- include/uapi/linux/virtio_ring.h | 10 ---------- 2 files changed, 6 insertions(+), 11 deletions(-)drivers/virtio/virtio_ring.c +6
-1@@ -152,7 +152,12 @@ struct vring_virtqueue {/* Available for packed ring */ struct {/* Actual memory layout for this queue. */ -struct vring_packed vring; +struct { +unsigned int num; +struct vring_packed_desc *desc; +struct vring_packed_desc_event *driver; +struct vring_packed_desc_event *device; + } vring;/* Driver ring wrap counter. */ bool avail_wrap_counter;include/uapi/linux/virtio_ring.h +0
-10@@ -213,14 +213,4 @@ struct vring_packed_desc { __le16 flags; }; -struct vring_packed { -unsigned int num; - -struct vring_packed_desc *desc; - -struct vring_packed_desc_event *driver; - -struct vring_packed_desc_event *device; -}; -#endif /* _UAPI_LINUX_VIRTIO_RING_H */ Signature · 1 line
MST