staging: most: cdev: add missing check for cdev_add failure
Subsystems (3)
PATCH 1/1 staging: most: cdev: add missing check for cdev_add failure
From: Colin Ian King <[email protected]>
Currently the call to cdev_add is missing a check for failure. Fix this by checking for failure and exiting via a new error path that ensures the allocated comp_channel struct is kfree'd.
Detected by CoverityScan, CID#1462359 ("Unchecked return value")
Fixes 9bc79bbcd0c5 ("Staging: most: add MOST driver's aim-cdev module")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/staging/most/cdev/cdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/most/cdev/cdev.c +4 -1
@@ -453,7 +453,9 @@ static int comp_probe(struct most_interface *iface, int channel_id, c->devno =MKDEV (comp.major, current_minor);cdev_init (&c->cdev, &channel_fops); c->cdev.owner =THIS_MODULE ; -cdev_add (&c->cdev, c->devno,1 ); + retval =cdev_add (&c->cdev, c->devno,1 ); +if (retval <0 ) + goto err_free_c; c->iface = iface; c->cfg = cfg; c->channel_id = channel_id;
@@ -485,6 +487,7 @@ static int comp_probe(struct most_interface *iface, int channel_id,list_del (&c->list); err_del_cdev_and_free_channel:cdev_del (&c->cdev); +err_free_c:kfree (c); err_remove_ida:ida_simple_remove (&comp.minor_id, current_minor);
Signature · 1 line
2.20.1