soc: fsl: dpio: Use after free in dpaa2_dpio_remove()
PATCH 1/1 soc: fsl: dpio: Use after free in dpaa2_dpio_remove()
The dpaa2_io_down(priv->io) call frees "priv->io" so I've shifted the code around a little bit to avoid the use after free.
Fixes 991e873223e9 ("soc: fsl: dpio: use a cpumask to identify which cpus are unused")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/soc/fsl/dpio/dpio-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/fsl/dpio/dpio-driver.c +1 -1
@@ -220,12 +220,12 @@ static int dpaa2_dpio_remove(struct fsl_mc_device *dpio_dev) dev = &dpio_dev->dev; priv =dev_get_drvdata (dev); + cpu =dpaa2_io_get_cpu (priv->io);dpaa2_io_down (priv->io);dpio_teardown_irqs (dpio_dev); - cpu =dpaa2_io_get_cpu (priv->io);cpumask_set_cpu (cpu, cpus_unused_mask); err = dpio_open(dpio_dev->mc_io, 0, dpio_dev->obj_desc.id,
Signature · 1 line
2.17.1
Li Yang
AppliedQuoted 6 lines · Dan Carpenter
The
dpaa2_io_down(priv->io)call frees "priv->io" so I've shifted the code around a little bit to avoid the use after free.Fixes 991e873223e9 ("soc: fsl: dpio: use a cpumask to identify which cpus are unused")Signed-off-by Dan Carpenter <[email protected]>
Applied. Thanks.
Quoted 25 lines
--- drivers/soc/fsl/dpio/dpio-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/fsl/dpio/dpio-driver.c +1
-2@@ -220,12 +220,12 @@ static int dpaa2_dpio_remove(struct fsl_mc_device *dpio_dev) dev = &dpio_dev->dev; priv =dev_get_drvdata (dev); + cpu =dpaa2_io_get_cpu (priv->io);dpaa2_io_down (priv->io);dpio_teardown_irqs (dpio_dev); - cpu =dpaa2_io_get_cpu (priv->io);cpumask_set_cpu (cpu, cpus_unused_mask); err = dpio_open(dpio_dev->mc_io, 0, dpio_dev->obj_desc.id, --2.17.1