Skip to contentSkip to conversation

pinctrl: samsung: Remove legacy API for handling external wakeup interrupts mask

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Feb 5, 2019 – Feb 8, 2019

Subsystems (4)
GPIO Arm Samsung Exynos Pin control Pin controller - Samsung
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v3 1/1 pinctrl: samsung: Remove legacy API for handling external wakeup interrupts mask

Remove the legacy, ugly API of exposing the static value of external wakeup interrupts mask, because all arch-machine users where converted to use generic implementation from pinctrl driver.

Signed-off-by Krzysztof Kozlowski <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Acked-by Tomasz Figa <[email protected]>

---

Dear Linus,

Could you apply this directly? It is an old cleanup patch, waiting for dependencies to get into mainline (v5.0-rc1).

Changes since v3:
1. Rebased on latest linux-next.

---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/pinctrl/samsung/pinctrl-exynos.c +2 -10
index f49ea3d92aa1..ebc27b06718c 100644
@@ -325,13 +325,6 @@ int exynos_eint_gpio_init(struct samsung_pinctrl_drv_data *d)
 	return ret;
 }
 
-static u32 exynos_eint_wake_mask = 0xffffffff;
-
-u32 exynos_get_eint_wake_mask(void)
-{
-	return exynos_eint_wake_mask;
-}
-
 static int exynos_wkup_irq_set_wake(struct irq_data *irqd, unsigned int on)
 {
 	struct irq_chip *chip = irq_data_get_irq_chip(irqd);

@@ -342,10 +335,9 @@ static int exynos_wkup_irq_set_wake(struct irq_data *irqd, unsigned int on)
 	pr_info("wake %s for irq %d\n", on ? "enabled" : "disabled", irqd->irq);
 
 	if (!on)
-		exynos_eint_wake_mask |= bit;
+		our_chip->eint_wake_mask_value |= bit;
 	else
-		exynos_eint_wake_mask &= ~bit;
-	our_chip->eint_wake_mask_value = exynos_eint_wake_mask;
+		our_chip->eint_wake_mask_value &= ~bit;
 
 	return 0;
 }
Signature · 1 line
2.17.1