vmw_balloon: 64-bit limit support, compaction, shrinker
cover vmw_balloon: 64-bit limit support, compaction, shrinker
Various enhancements for VMware balloon, some of which are remainder from a previous patch-set.
Patch 1: Aumps the version number, following recent changes Patch 2: Adds support for 64-bit memory limit Patches 3-4: Support for compaction
Patch 5: Support for memory shrinker - disabled by default Patch 6: Split refused pages to improve performance
Since the 3rd patch requires Michael Tsirkin ack, which has not arrived in the last couple of times the patch was sent, please consider applying patches 1-2 for 5.1.
Nadav Amit (5):
vmw_balloon: bump version number
mm/balloon_compaction: list interfaces
vmw_balloon: compaction support
vmw_balloon: add memory shrinker
vmw_balloon: split refused pages
Xavier Deguillard (1):
vmw_balloon: support 64-bit memory limit
drivers/misc/Kconfig | 1 + drivers/misc/vmw_balloon.c | 511 ++++++++++++++++++++++++++--- include/linux/balloon_compaction.h | 4 + mm/balloon_compaction.c | 139 +++++--- 4 files changed, 566 insertions(+), 89 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/6 vmw_balloon: bump version number
Following recent changes.
--- drivers/misc/vmw_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_balloon.c +1 -1
@@ -34,7 +34,7 @@MODULE_AUTHOR ("VMware, Inc." );MODULE_DESCRIPTION ("VMware Memory Control (Balloon) Driver" ); -MODULE_VERSION ("1.5.0.0-k" ); +MODULE_VERSION ("1.6.0.0-k" );MODULE_ALIAS ("dmi:*:svnVMware*:*" );MODULE_ALIAS ("vmware_vmmemctl" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerRe: [PATCH 1/6] vmw_balloon: bump version number
Quoted 12 lines · Nadav Amit
Following recent changes.
Signed-off-by Nadav Amit <[email protected]>--- drivers/misc/vmw_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/vmw_balloon.c +0
-0
drivers/misc/vmw_balloon.c line 37
Quoted 5 lines
drivers/misc/vmw_balloon.c +1
-1@@ -34,7 +34,7 @@MODULE_AUTHOR ("VMware, Inc." );MODULE_DESCRIPTION ("VMware Memory Control (Balloon) Driver" ); -MODULE_VERSION ("1.5.0.0-k" ); +MODULE_VERSION ("1.6.0.0-k" );
Please just drop this pointless line, it means nothing and is always out of date. It's been removed from many other drivers, and I really don't want to see it come back.
Your driver "version" is the kernel version, full stop. That's all you need to ever worry about.
thanks,
greg k-h
Michael S. Tsirkin
maintainerQuoted 9 lines · Nadav Amit
Various enhancements for VMware balloon, some of which are remainder from a previous patch-set.
Patch 1: Aumps the version number, following recent changes Patch 2: Adds support for 64-bit memory limit Patches 3-4: Support for compaction
Patch 5: Support for memory shrinker - disabled by default Patch 6: Split refused pages to improve performance
Quoted 8 lines
Since the 3rd patch requires Michael Tsirkin ack, which has not arrived in the last couple of times the patch was sent, please consider applying patches 1-2 for 5.1.
Cc "Michael S. Tsirkin" <[email protected]>Cc Jason Wang <[email protected]>
I don't seem to have got anything except patch 0 either directly or through [email protected] Could you bounce the relevant patches there?
Thanks!
Quoted 18 lines
Nadav Amit (5):
vmw_balloon: bump version number
mm/balloon_compaction: list interfaces
vmw_balloon: compaction support
vmw_balloon: add memory shrinker
vmw_balloon: split refused pagesXavier Deguillard (1):
vmw_balloon: support 64-bit memory limitdrivers/misc/Kconfig | 1 + drivers/misc/vmw_balloon.c | 511 ++++++++++++++++++++++++++--- include/linux/balloon_compaction.h | 4 + mm/balloon_compaction.c | 139 +++++--- 4 files changed, 566 insertions(+), 89 deletions(-)Signature · 1 line
2.17.1
Michael S. Tsirkin
maintainerQuoted 9 lines · Nadav Amit
Various enhancements for VMware balloon, some of which are remainder from a previous patch-set.
Patch 1: Aumps the version number, following recent changes Patch 2: Adds support for 64-bit memory limit Patches 3-4: Support for compaction
Patch 5: Support for memory shrinker - disabled by default Patch 6: Split refused pages to improve performance
Quoted 8 lines
Since the 3rd patch requires Michael Tsirkin ack, which has not arrived in the last couple of times the patch was sent, please consider applying patches 1-2 for 5.1.
Cc "Michael S. Tsirkin" <[email protected]>Cc Jason Wang <[email protected]>
I don't seem to have got anything except patch 0 either directly or through [email protected] Could you bounce the relevant patches there?
Thanks!
Quoted 18 lines
Nadav Amit (5):
vmw_balloon: bump version number
mm/balloon_compaction: list interfaces
vmw_balloon: compaction support
vmw_balloon: add memory shrinker
vmw_balloon: split refused pagesXavier Deguillard (1):
vmw_balloon: support 64-bit memory limitdrivers/misc/Kconfig | 1 + drivers/misc/vmw_balloon.c | 511 ++++++++++++++++++++++++++--- include/linux/balloon_compaction.h | 4 + mm/balloon_compaction.c | 139 +++++--- 4 files changed, 566 insertions(+), 89 deletions(-)Signature · 1 line
2.17.1
Quoted 22 lines · Michael S. Tsirkin
Quoted 9 lines · Nadav Amit
Various enhancements for VMware balloon, some of which are remainder from a previous patch-set.
Patch 1: Aumps the version number, following recent changes Patch 2: Adds support for 64-bit memory limit Patches 3-4: Support for compaction
Patch 5: Support for memory shrinker - disabled by default Patch 6: Split refused pages to improve performanceQuoted 8 lines
Since the 3rd patch requires Michael Tsirkin ack, which has not arrived in the last couple of times the patch was sent, please consider applying patches 1-2 for 5.1.
Cc "Michael S. Tsirkin" <[email protected]>Cc Jason Wang <[email protected]>
Quoted 3 lines
I don't seem to have got anything except patch 0 either directly or through [email protected] Could you bounce the relevant patches there?
Sorry for that. I will resend.
Re: [PATCH 1/6] vmw_balloon: bump version number
In reply to Greg Kroah-HartmanQuoted 25 lines · Greg Kroah-Hartman
Quoted 12 lines · Nadav Amit
Following recent changes.
Signed-off-by Nadav Amit <[email protected]>---
drivers/misc/vmw_balloon.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/vmw_balloon.c +0
-0drivers/misc/vmw_balloon.c line 37
Quoted 5 lines
drivers/misc/vmw_balloon.c +1
-1@@ -34,7 +34,7 @@MODULE_AUTHOR ("VMware, Inc." );MODULE_DESCRIPTION ("VMware Memory Control (Balloon) Driver" ); -MODULE_VERSION ("1.5.0.0-k" ); +MODULE_VERSION ("1.6.0.0-k" );Please just drop this pointless line, it means nothing and is always out of date. It's been removed from many other drivers, and I really don't want to see it come back.
Quoted 2 lines
Your driver "version" is the kernel version, full stop. That's all you need to ever worry about.
I understand, and I will inform those who asked for the version bump.
Having said that, I do not see a reference for this policy. I understand that you removed the MODULE_VERSION from in-kernel drivers, but I also see that you accepted several drivers last year that used MODULE_VERSION.
Greg Kroah-Hartman
maintainerRe: [PATCH 1/6] vmw_balloon: bump version number
Quoted 25 lines · Nadav Amit
Quoted 25 lines · Greg Kroah-Hartman
Quoted 12 lines · Nadav Amit
Following recent changes.
Signed-off-by Nadav Amit <[email protected]>---
drivers/misc/vmw_balloon.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/vmw_balloon.c +0
-0drivers/misc/vmw_balloon.c line 37
Quoted 5 lines
drivers/misc/vmw_balloon.c +1
-1@@ -34,7 +34,7 @@MODULE_AUTHOR ("VMware, Inc." );MODULE_DESCRIPTION ("VMware Memory Control (Balloon) Driver" ); -MODULE_VERSION ("1.5.0.0-k" ); +MODULE_VERSION ("1.6.0.0-k" );Please just drop this pointless line, it means nothing and is always out of date. It's been removed from many other drivers, and I really don't want to see it come back.
Quoted 8 lines
Quoted 2 lines
Your driver "version" is the kernel version, full stop. That's all you need to ever worry about.
I understand, and I will inform those who asked for the version bump.
Having said that, I do not see a reference for this policy. I understand that you removed the
MODULE_VERSIONfrom in-kernel drivers, but I also see that you accepted several drivers last year that usedMODULE_VERSION.
I messed up, and will be glad to take patches to remove them. Usually that's the last thing I remember to check when reviewing patches, I can always use the help :)
Also, I only received 1 patch in this series, did something go wrong with the sending of it?
thanks,
greg k-h
Re: [PATCH 1/6] vmw_balloon: bump version number
Quoted 37 lines · Greg Kroah-Hartman
Quoted 25 lines · Nadav Amit
Quoted 25 lines · Greg Kroah-Hartman
Quoted 12 lines · Nadav Amit
Following recent changes.
Signed-off-by Nadav Amit <[email protected]>---
drivers/misc/vmw_balloon.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/vmw_balloon.c +0
-0drivers/misc/vmw_balloon.c line 37
Quoted 5 lines
drivers/misc/vmw_balloon.c +1
-1@@ -34,7 +34,7 @@MODULE_AUTHOR ("VMware, Inc." );MODULE_DESCRIPTION ("VMware Memory Control (Balloon) Driver" ); -MODULE_VERSION ("1.5.0.0-k" ); +MODULE_VERSION ("1.6.0.0-k" );Please just drop this pointless line, it means nothing and is always out of date. It's been removed from many other drivers, and I really don't want to see it come back.
Quoted 8 lines
Quoted 2 lines
Your driver "version" is the kernel version, full stop. That's all you need to ever worry about.
I understand, and I will inform those who asked for the version bump.
Having said that, I do not see a reference for this policy. I understand that you removed the
MODULE_VERSIONfrom in-kernel drivers, but I also see that you accepted several drivers last year that usedMODULE_VERSION.
Quoted 6 lines
I messed up, and will be glad to take patches to remove them. Usually that's the last thing I remember to check when reviewing patches, I can always use the help :)
Also, I only received 1 patch in this series, did something go wrong with the sending of it?
Err. Thanks for letting me know. I guess that that I messed up the git-send trying to avoid cc’ing patch author who got his email address deactivated.
I will resend.