Skip to contentSkip to conversation

softfloat: add float128_is_{normal, denormal}

PATCH Applied David Hildenbrand 3 participants 3 messages Feb 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 softfloat: add float128_is_{normal, denormal}

Needed on s390x, to test for the data class of a number. So it will gain soon a user.

A number is considered normal if the exponent is neither 0 nor all 1's. That can be checked by adding 1 to the exponent, and comparing against

Quoted 1 line

= 2 after dropping an eventual overflow into the sign bit.

While at it, convert the other floatXX_is_normal functions to use a similar, less error prone calculation, as suggested by Richard H.

---
 include/fpu/softfloat.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
include/fpu/softfloat.h +12 -2
index 38a5e99cf3..3ff5215b81 100644
@@ -466,7 +466,7 @@ static inline int float32_is_zero_or_denormal(float32 a)
 
 static inline bool float32_is_normal(float32 a)
 {
-    return ((float32_val(a) + 0x00800000) & 0x7fffffff) >= 0x01000000;
+    return (((float32_val(a) >> 23) + 1) & 0xff) >= 2;
 }
 
 static inline bool float32_is_denormal(float32 a)
@@ -622,7 +622,7 @@ static inline int float64_is_zero_or_denormal(float64 a)
 
 static inline bool float64_is_normal(float64 a)
 {
-    return ((float64_val(a) + (1ULL << 52)) & -1ULL >> 1) >= 1ULL << 53;
+    return (((float64_val(a) >> 52) + 1) & 0x7ff) >= 2;
 }
 
 static inline bool float64_is_denormal(float64 a)
@@ -940,6 +940,16 @@ static inline int float128_is_zero_or_denormal(float128 a)
     return (a.high & 0x7fff000000000000LL) == 0;
 }
 
+static inline bool float128_is_normal(float128 a)
+{
+    return (((a.high >> 48) + 1) & 0x7fff) >= 2;
+}
+
+static inline bool float128_is_denormal(float128 a)
+{
+    return float128_is_zero_or_denormal(a) && !float128_is_zero(a);
+}
+
 static inline int float128_is_any_nan(float128 a)
 {
     return ((a.high >> 48) & 0x7fff) == 0x7fff &&
Signature · 1 line
2.17.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · David Hildenbrand

Needed on s390x, to test for the data class of a number. So it will gain soon a user.

A number is considered normal if the exponent is neither 0 nor all 1's. That can be checked by adding 1 to the exponent, and comparing against

Quoted 8 lines
Quoted 1 line

= 2 after dropping an eventual overflow into the sign bit.

While at it, convert the other floatXX_is_normal functions to use a similar, less error prone calculation, as suggested by Richard H.

---
 include/fpu/softfloat.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

r~

Applied
#2 lore raw
In reply to David Hildenbrand
Quoted 9 lines · David Hildenbrand

Needed on s390x, to test for the data class of a number. So it will gain soon a user.

A number is considered normal if the exponent is neither 0 nor all 1's. That can be checked by adding 1 to the exponent, and comparing against

Quoted 1 line

= 2 after dropping an eventual overflow into the sign bit.

While at it, convert the other floatXX_is_normal functions to use a similar, less error prone calculation, as suggested by Richard H.

Queued to fpu/next, thanks.

--
Alex Bennée