tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE

PATCH In review Katarzyna Dec 3 participants 6 messages Feb 7, 2019

lore

Share & tools

lore

Katarzyna Dec

author

2019-02-07 08:08 UTC #0 lore raw

PATCH 1/1 tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE

When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE to 1M which is not reflected in test_close() loop.

Signed-off-by Katarzyna Dec <[email protected]>

Cc Chris Wilson <[email protected]>

Cc Lukasz Kalamarz <[email protected]>

---
 tests/i915/gem_mmap_wc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tests/i915/gem_mmap_wc.c +1 -1

index 110883eb..bff0fa2a 100644
@@ -285,7 +285,7 @@ test_close(int fd)
 
 	memset(ptr, 0xcc, OBJECT_SIZE);
 	gem_close(fd, handle);
-	for (i = 0; i < 4096; i++)
+	for (i = 0; i < OBJECT_SIZE/4096; i++)
 		igt_assert(ptr[i*4096+i] == 0xcc);
 
 	munmap(ptr, OBJECT_SIZE);

Signature · 6 lines

2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Chris Wilson

2019-02-07 08:13 UTC #1 lore raw

Quoting Katarzyna Dec (2019-02-07 08:08:04)

Quoted 2 lines

When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE to 1M which is not reflected in test_close() loop.

Why would you bother running this test on simulation? It's just a test of the kernel reference counting.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Katarzyna Dec

author

2019-02-07 08:34 UTC #2 lore raw

Quoted 7 lines · Chris Wilson

Quoting Katarzyna Dec (2019-02-07 08:08:04)
Quoted 2 lines
When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE to 1M which is not reflected in test_close() loop.
Why would you bother running this test on simulation? It's just a test of the kernel reference counting.
-Chris

So why do we have different object size for simulation in this test when we should not bother?
Btw - I am fixing a bug in your code.
I wanted to talk to you on irc, but something is not working for me....

Kasia :)
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Chris Wilson

2019-02-07 08:41 UTC #3 lore raw

Quoting Katarzyna Dec (2019-02-07 08:34:44)

Quoted 10 lines · Chris Wilson

Quoted 7 lines
Quoting Katarzyna Dec (2019-02-07 08:08:04)
Quoted 2 lines
When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE to 1M which is not reflected in test_close() loop.
Why would you bother running this test on simulation? It's just a test of the kernel reference counting.
-Chris
So why do we have different object size for simulation in this test when we should not bother?

No idea. All hw interaction should be covered by selftests (this certainly is), the raison d'etre for igt is to cover user observable behaviour. For the simulator, we should just be able to use seftests followed by bare uABI checks before moving onto real workloads.

Quoted 1 line

Btw - I am fixing a bug in your code.

Nope, that is nothing to do with me. Someone else thought is was a good idea. I do not like having tests vary, make different tests. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-02-07 08:41 UTC #4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE

In reply to Katarzyna Dec

== Series Details ==

Series: tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
URL : https://patchwork.freedesktop.org/series/56329/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5557 -> IGTPW_2349
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56329/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2349 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527

Participating hosts (47 -> 44)
------------------------------

Additional (3): fi-skl-guc fi-skl-6770hq fi-hsw-peppy
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4812 -> IGTPW_2349

CI_DRM_5557: 72302b1c5245655423f75a857aec82f037991b6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2349: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
IGT_4812: 592b854fead32c2b0dac7198edfb9a6bffd66932 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-02-07 10:30 UTC #5 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE

In reply to Katarzyna Dec

== Series Details ==

Series: tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
URL : https://patchwork.freedesktop.org/series/56329/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5557_full -> IGTPW_2349_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56329/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2349_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_params@secure-non-root:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]

* igt@gem_exec_schedule@pi-ringfull-bsd2:
- shard-kbl: NOTRUN -> FAIL [fdo#103158] +2

* igt@gem_mmap_gtt@hang:
- shard-kbl: NOTRUN -> FAIL [fdo#109469]

* igt@gem_partial_pwrite_pread@writes-after-reads-snoop:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

* igt@i915_suspend@sysfs-reader:
- shard-snb: PASS -> FAIL [fdo#103375]

* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
- shard-glk: PASS -> FAIL [fdo#106641]

* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956] +3

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_busy@extended-pageflip-hang-newfb-render-a:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]

* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] +1

* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +2
- shard-kbl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2

* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-glk: PASS -> FAIL [fdo#100368]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +3

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590] +2

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +4

* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +3

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +2

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]

#### Possible fixes ####

* igt@gem_exec_blt@cold-min:
- shard-glk: DMESG-WARN [fdo#105763] / [fdo#106538] -> PASS

* igt@i915_selftest@live_hangcheck:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS +1

* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +3

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS +3

* igt@kms_flip@basic-plain-flip:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- shard-snb: {SKIP} [fdo#109271] -> PASS +5

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3

* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS
- shard-kbl: FAIL [fdo#103166] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2

* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS

#### Warnings ####

* igt@i915_suspend@shrink:
- shard-glk: DMESG-WARN [fdo#109244] -> INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4812 -> IGTPW_2349
* Piglit: piglit_4509 -> None

== Logs ==