Trivial fixes for configure and Python scripts
cover Trivial fixes for configure and Python scripts
This is just a small collection of trivial fixes for configure and some Python scripts (missing/unused import statements).
Cleber Rosa (4):
configure: remove handling of "wav" audio driver
configure: fix qemu-img name scripts/render_block_graph.py: add a missing import tests/migration/guestperf/engine.py: remove unused import
configure | 6 +----- scripts/render_block_graph.py | 1 + tests/migration/guestperf/engine.py | 1 - 3 files changed, 2 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/4 configure: remove handling of "wav" audio driver
This looks like a leftover that was never implemented.
--- configure | 4 ---- 1 file changed, 4 deletions(-)
configure +0 -4
@@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do oss_libs="$oss_lib" ;; - wav) - # XXX: Probes for CoreAudio, DirectSound - ;; - *) echo "$audio_possible_drivers" | grep -q "\<$drv\>" || { error_exit "Unknown driver '$drv' selected" \
Signature · 1 line
2.20.1
PATCH 2/4 configure: fix qemu-img name
In reply to Cleber Rosa--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available: virglrenderer virgl rendering support xfsctl xfsctl support qom-cast-debug cast debugging support - tools build qemu-io, qemu-nbd and qemu-image tools + tools build qemu-io, qemu-nbd and qemu-img tools vxhs Veritas HyperScale vDisk backend support bochs bochs image format support cloop cloop image format support
Signature · 1 line
2.20.1
PATCH 3/4 scripts/render_block_graph.py: add a missing import
In reply to Cleber RosaThe handle to QMP may be one of two classes, one implemented locally, and the other one, which seems to be from "qmp.qmp", but of which an import is missing.
--- scripts/render_block_graph.py | 1 + 1 file changed, 1 insertion(+)
scripts/render_block_graph.py +1 -0
@@ -24,6 +24,7 @@ import subprocess import json from graphviz import Digraph from qemu import MonitorResponseError +from qmp.qmp import QEMUMonitorProtocol def perm(arr):
Signature · 1 line
2.20.1
PATCH 4/4 tests/migration/guestperf/engine.py: remove unused import
In reply to Cleber Rosa--- tests/migration/guestperf/engine.py | 1 - 1 file changed, 1 deletion(-)
tests/migration/guestperf/engine.py +0 -1
@@ -26,7 +26,6 @@ import time sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', '..', 'scripts')) import qemu -import qmp.qmp from guestperf.progress import Progress, ProgressStats from guestperf.report import Report from guestperf.timings import TimingRecord, Timings
Signature · 1 line
2.20.1
Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver
In reply to Cleber RosaQuoted 13 lines · Cleber Rosa
This looks like a leftover that was never implemented.
Signed-off-by Cleber Rosa <[email protected]>--- configure | 4 ---- 1 file changed, 4 deletions(-)configure +0
-0
configure for drv in $audio_drv_list; do · line 3355
Quoted 10 lines
configure +0
-4@@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do oss_libs="$oss_lib" ;; - wav) - # XXX: Probes for CoreAudio, DirectSound - ;; - *) echo "$audio_possible_drivers" | grep -q "\<$drv\>" || { error_exit "Unknown driver '$drv' selected" \
Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name
In reply to Cleber RosaQuoted 11 lines · Cleber Rosa
Signed-off-by Cleber Rosa <[email protected]>--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure +0
-0
configure disabled with --disable-FEATURE, default is enabled if available: · line 1774
Quoted 8 lines
configure +1
-1@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available: virglrenderer virgl rendering support xfsctl xfsctl support qom-cast-debug cast debugging support - tools build qemu-io, qemu-nbd and qemu-image tools + tools build qemu-io, qemu-nbd and qemu-img tools vxhs Veritas HyperScale vDisk backend support bochs bochs image format support cloop cloop image format support
optional features")
Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?
Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver
In reply to Cleber RosaQuoted 13 lines · Cleber Rosa
This looks like a leftover that was never implemented.
Signed-off-by Cleber Rosa <[email protected]>--- configure | 4 ---- 1 file changed, 4 deletions(-)configure +0
-0
configure for drv in $audio_drv_list; do · line 3355
Quoted 10 lines
configure +0
-4@@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do oss_libs="$oss_lib" ;; - wav) - # XXX: Probes for CoreAudio, DirectSound - ;; - *) echo "$audio_possible_drivers" | grep -q "\<$drv\>" || { error_exit "Unknown driver '$drv' selected" \
Philippe Mathieu-Daudé
Reviewed-byRe: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name
In reply to Laurent VivierQuoted 22 lines · Laurent Vivier
Quoted 11 lines · Cleber Rosa
Signed-off-by Cleber Rosa <[email protected]>--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure +0
-0configure disabled with --disable-FEATURE, default is enabled if available: · line 1774
Quoted 8 lines
configure +1
-1@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available: virglrenderer virgl rendering support xfsctl xfsctl support qom-cast-debug cast debugging support - tools build qemu-io, qemu-nbd and qemu-image tools + tools build qemu-io, qemu-nbd and qemu-img tools vxhs Veritas HyperScale vDisk backend support bochs bochs image format support cloop cloop image format supportFixes c12d66aac1aa ("configure: add the missing help output for
Quoted 3 lines
optional features")
Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?
Good idea! Eventually the trivial@ maintainer is willing to fulfil your request if he takes this patch :D
Quoted 1 line
Reviewed-by Laurent Vivier <[email protected]>
As it or with Laurent's suggestion:
Laurent Vivier
AppliedRe: [Qemu-devel] [Qemu-trivial] [PATCH 1/4] configure: remove handling of "wav" audio driver
In reply to Cleber RosaQuoted 13 lines · Cleber Rosa
This looks like a leftover that was never implemented.
Signed-off-by Cleber Rosa <[email protected]>--- configure | 4 ---- 1 file changed, 4 deletions(-)configure +0
-0
configure for drv in $audio_drv_list; do · line 3355
Quoted 10 lines
configure +0
-4@@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do oss_libs="$oss_lib" ;; - wav) - # XXX: Probes for CoreAudio, DirectSound - ;; - *) echo "$audio_possible_drivers" | grep -q "\<$drv\>" || { error_exit "Unknown driver '$drv' selected" \
Applied to my trivial-patches branch.
Thanks,
Laurent
Laurent Vivier
AppliedRe: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] configure: fix qemu-img name
In reply to Cleber RosaQuoted 11 lines · Cleber Rosa
Signed-off-by Cleber Rosa <[email protected]>--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure +0
-0
configure disabled with --disable-FEATURE, default is enabled if available: · line 1774
Quoted 8 lines
configure +1
-1@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available: virglrenderer virgl rendering support xfsctl xfsctl support qom-cast-debug cast debugging support - tools build qemu-io, qemu-nbd and qemu-image tools + tools build qemu-io, qemu-nbd and qemu-img tools vxhs Veritas HyperScale vDisk backend support bochs bochs image format support cloop cloop image format support
Applied to my trivial-patches branch.
Thanks,
Laurent
Quoted 9 lines · Cleber Rosa
This is just a small collection of trivial fixes for configure and some Python scripts (missing/unused import statements).
Cleber Rosa (4):
configure: remove handling of "wav" audio driver
configure: fix qemu-img namescripts/render_block_graph.py: add a missing importtests/migration/guestperf/engine.py: remove unused import
Quoted 5 lines
configure | 6 +----- scripts/render_block_graph.py | 1 + tests/migration/guestperf/engine.py | 1 - 3 files changed, 2 insertions(+), 6 deletions(-)
I've applied to my trivial-patches branchi patches 1 and 2, but not 3 and 4 as I don't know python and no one has reviewed them.
Thanks,
Laurent