can: kvaser_usb: Use struct_size() in alloc_candev()
Subsystems (3)
PATCH 1/1 can: kvaser_usb: Use struct_size() in alloc_candev()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};instance = alloc(sizeof(struct foo) + count * sizeof(void *));
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = alloc(struct_size(instance, entry, count));
This code was detected with the help of Coccinelle.
--- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c +1 -2
@@ -643,8 +643,7 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev,return err; } - netdev =alloc_candev (sizeof (*priv) + - dev->max_tx_urbs *sizeof (*priv->tx_contexts), + netdev =alloc_candev (struct_size (priv, tx_contexts, dev->max_tx_urbs), dev->max_tx_urbs);if (!netdev) {dev_err (&dev->intf->dev,"Cannot alloc candev\n" );
Signature · 1 line
2.20.1
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
Quoted 38 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };instance =
alloc(sizeof(struct foo) + count * sizeof(void *));Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
alloc(struct_size(instance, entry, count));This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c +1
-2@@ -643,8 +643,7 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev,return err; } - netdev =alloc_candev (sizeof (*priv) + - dev->max_tx_urbs *sizeof (*priv->tx_contexts), + netdev =alloc_candev (struct_size (priv, tx_contexts, dev->max_tx_urbs), dev->max_tx_urbs);if (!netdev) {dev_err (&dev->intf->dev,"Cannot alloc candev\n" );
Quoted 11 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };instance =
alloc(sizeof(struct foo) + count * sizeof(void *));
Quoted 8 lines
Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
alloc(struct_size(instance, entry, count));This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied to linux-can-next.
Tnx,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Hi Marc,
Quoted 15 lines · Marc Kleine-Budde
Quoted 14 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };instance =
alloc(sizeof(struct foo) + count * sizeof(void *));Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:
Quoted 8 lines
Quoted 5 lines
instance =
alloc(struct_size(instance, entry, count));This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied to linux-can-next.
I noticed this patch is not in linux-next.
I wonder if you actually applied it to your tree.
Thanks
--
Gustavo
Hi all,
Friendly ping(second one):
Who can take this?
Thanks
--
Gustavo
Quoted 49 lines · Gustavo A. R. Silva
Hi all,
Friendly ping:
Who can take this?
Thanks
--
GustavoQuoted 38 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };instance =
alloc(sizeof(struct foo) + count * sizeof(void *));Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
alloc(struct_size(instance, entry, count));This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c +1
-2@@ -643,8 +643,7 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev,return err; } - netdev =alloc_candev (sizeof (*priv) + - dev->max_tx_urbs *sizeof (*priv->tx_contexts), + netdev =alloc_candev (struct_size (priv, tx_contexts, dev->max_tx_urbs), dev->max_tx_urbs);if (!netdev) {dev_err (&dev->intf->dev,"Cannot alloc candev\n" );