Skip to contentSkip to conversation

arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues

PATCH In review Peter Geis 2 participants 2 messages Feb 10, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Peter Geis

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues

This patch is a port of the fix from
commit 73e42e186699 ("arm64: dts: rockchip: fix rock64 gmac2io stability issues")

As per that patch, enabling thresh dma mode force disables checksuming. This is necessary as tx checksuming does not work with packets larger than 1498.

The rk3328-roc-cc board exhibits tx stability issues with large packets similar to rock64's issues. This patch resolves that issue.

---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +1 -0
index 99d0d9912950..33c44e857247 100644
@@ -104,6 +104,7 @@
 	phy-mode = "rgmii";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmiim1_pins>;
+	snps,force_thresh_dma_mode;
 	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): 20190210170214.12057-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Hi Peter,

Am Sonntag, 10. Februar 2019, 18:02:14 CET schrieb Peter Geis:

Quoted 10 lines

This patch is a port of the fix from
commit 73e42e186699 ("arm64: dts: rockchip: fix rock64 gmac2io stability issues")

As per that patch, enabling thresh dma mode force disables checksuming. This is necessary as tx checksuming does not work with packets larger than 1498.

The rk3328-roc-cc board exhibits tx stability issues with large packets similar to rock64's issues. This patch resolves that issue.

Patch itself looks good, but here you're missing a Signed-off-by line, see
Documentation/process/submitting-patches.rst
section "11) Sign your work - the Developer's Certificate of Origin" for reference

Heiko