pci: Add comment to mention difference in DEVFN usage in U-Boot vs Linux
PATCH 1/1 pci: Add comment to mention difference in DEVFN usage in U-Boot vs Linux
This patch adds a comment to the header with the PCI_foo macros related to DEVFN to explain the difference in U-Boot vs Linux.
Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
--- include/pci.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/pci.h +11 -0
@@ -499,9 +499,20 @@ static inline void pci_set_region(struct pci_region *reg,typedef int pci_dev_t ;#define PCI_BUS (d) (((d) >> 16) & 0xff) + +/* +* Please note the difference in DEVFN usage in U-Boot vs Linux. U-Boot +* uses DEVFN in bits 15-8 but Linux instead expects DEVFN in bits 7-0. +* Please see the Linux header include/uapi/linux/pci.h for more details. +* This is relevant for the following macros: +* PCI_DEV, PCI_FUNC, PCI_DEVFN +* The U-Boot macro PCI_DEV is equivalent to the Linux PCI_SLOT version with +* the remark from above (input d in bits 15-8 instead of 7-0. +*/ #define PCI_DEV (d) (((d) >> 11) & 0x1f)#define PCI_FUNC (d) (((d) >> 8) & 0x7)#define PCI_DEVFN (d, f) ((d) << 11 | (f) << 8) +#define PCI_MASK_BUS (bdf) ((bdf) & 0xffff)#define PCI_ADD_BUS (bus, devfn) (((bus) << 16) | (devfn))#define PCI_BDF (b, d, f) ((b) << 16 | PCI_DEVFN(d, f))
Signature · 1 line
2.20.1
PATCH 1/1 pci: Add comment to mention difference in DEVFN usage in U-Boot vs Linux
Quoted 11 lines · Stefan Roese
This patch adds a comment to the header with the
PCI_foomacros related to DEVFN to explain the difference in U-Boot vs Linux.Signed-off-by Stefan Roese <[email protected]>Cc Simon Glass <[email protected]>Cc Bin Meng <[email protected]>--- include/pci.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
Reviewed-by Simon Glass <[email protected]>
Quoted 7 lines · Stefan Roese
This patch adds a comment to the header with the
PCI_foomacros related to DEVFN to explain the difference in U-Boot vs Linux.Signed-off-by Stefan Roese <[email protected]>Cc Simon Glass <[email protected]>Cc Bin Meng <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190322/adb38f42/attachment.sig>