systemd: RDEPENDS on util-linux-umount
PATCH 1/1 systemd: RDEPENDS on util-linux-umount
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
---
this should only be merged with or after the util-linux packaging rework
--- meta/recipes-core/systemd/systemd_239.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_239.bb +1 -1
@@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \ FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd" -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck" +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck" RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}" RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
Signature · 1 line
2.20.1
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
Quoted 35 lines · André Draszik
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
Signed-off-by André Draszik <[email protected]>---
this should only be merged with or after the util-linux packaging rework--- meta/recipes-core/systemd/systemd_239.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes- renamed from meta/recipes-core/systemd/systemd_239.bb +0
-0core/systemd/systemd_239.bb
indexf843f588bd..e2dfe639b3100644meta/recipes-core/systemd/systemd_239.bb +0
-0@@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \ FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
-RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
generator', '', 'systemd-serialgetty', d)}"
RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
Quoted 1 line · André Draszik
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
FWIW, I would like to see this patch merged. Had some issues in the past with busybox umount and added same change as a bbappend.
-Mikko
Quoted 42 lines · André Draszik
Quoted 35 lines
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
Signed-off-by André Draszik <[email protected]>---
this should only be merged with or after the util-linux packaging rework--- meta/recipes-core/systemd/systemd_239.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes- renamed from meta/recipes-core/systemd/systemd_239.bb +0
-0core/systemd/systemd_239.bb
indexf843f588bd..e2dfe639b3100644meta/recipes-core/systemd/systemd_239.bb +0
-0@@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \ FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
-RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
generator', '', 'systemd-serialgetty', d)}"
RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"Signature · 4 lines
_______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 5 lines · On 11/02/2019 13:15, [email protected] wrote:
Quoted 1 line · André Draszik
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
FWIW, I would like to see this patch merged. Had some issues in the past with busybox umount and added same change as a bbappend.
I'm also carrying a patch locally for this with the following explanation:
systemd passes the "-c" parameter (do not canonicalize) to the umount command and busybox's umount does not understand this parameter.
/Jonas
Quoted 4 lines · Jonas Bonn
Quoted 1 line · On 11/02/2019 13:15, [email protected] wrote:
On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
FWIW, I would like to see this patch merged. Had some issues in the past with busybox umount and added same change as a bbappend.
I'm also carrying a patch locally for this with the following explanation:
systemd passes the "-c" parameter (do not canonicalize) to the umount command and busybox's umount does not understand this parameter.
With the current busybox do you really still see a problem since busybox umount has been told to ignore "-c" now:
https://git.busybox.net/busybox/commit/?id=426134128112738c97a665170b21153ef0764b7d
umount: ignore -c
"-c, --no-canonicalize: Do not canonicalize paths."
As busybox doesn't canonicalize paths in the first place it is safe to ignore this option.
See https://github.com/systemd/systemd/issues/7786
and that's released in:
$ git tag --contains 426134128112738c97a665170b21153ef0764b7d 1_29_0 1_29_1 1_29_2 1_29_3 1_30_0
and we have:
meta/recipes-core/busybox/busybox_1.29.3.bb
Signature · 2 lines
# Randy MacLeod # Wind River Linux
Quoted 10 lines · Randy MacLeod
Quoted 9 lines · Jonas Bonn
Quoted 5 lines · On 11/02/2019 13:15, [email protected] wrote:
Quoted 1 line · André Draszik
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
FWIW, I would like to see this patch merged. Had some issues in the past with busybox umount and added same change as a bbappend.
Quoted 6 lines
Quoted 3 lines
I'm also carrying a patch locally for this with the following explanation:
systemd passes the "-c" parameter (do not canonicalize) to the umount command and busybox's umount does not understand this parameter.
With the current busybox do you really still see a problem since busybox umount has been told to ignore "-c" now:
OK, my patch predates the fix in busybox and I haven't tested without it recently. Previously umount would error out due to the unknown option and systemd-mount would fail rather inelegantly; the busybox fix should be sufficient to rectify this.
/Jonas